Clear AGP-10 deprecations + enable Gradle configuration cache#62
Conversation
- Remove android.enableJetifier=true. 'gradlew checkJetifier' confirms no module uses legacy android.support.* libraries, so Jetifier transforms nothing. The flag is removed in AGP 10; omitting it adopts the default (false). - Remove android.nonFinalResIds=false to adopt the AGP 9 default (true). No Java 'switch (R.id.x)'/'case R.id.x:' usage exists (all switches are on protocol/type/authType ints), so non-final R ids are safe. Flag removed in AGP 10. - Enable org.gradle.configuration-cache=true. Verified: a clean app:assembleOssDebug stores the entry, and a re-run reuses it (47s -> 1s) with renameApksForOssDebug still producing the NekoBox-*-<abi>.apk files. Both deprecation warnings that AGP 9 emitted are now gone.
|
Warning Review limit reached
More reviews will be available in 20 minutes. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. Comment |
Summary
Follow-up to #61. Clears the two AGP-10 deprecation warnings AGP 9 emitted and enables the Gradle configuration cache.
Changes (
gradle.propertiesonly)android.enableJetifier=true../gradlew checkJetifierreports "Project ':app' does not use any legacy support libraries", and nocom.android.support/android.archartifacts appear in the resolved runtime classpath. Jetifier was transforming nothing. The flag is removed in AGP 10, so omitting it adopts the default (false).android.nonFinalResIds=falseto adopt the AGP 9 default (true). The only risk with non-final R ids is Javaswitch (R.id.x)/case R.id.x:(which require compile-time constants); the project has none — every Javaswitchis onprotocol/type/authTypeints. Flag is removed in AGP 10.org.gradle.configuration-cache=true(stable since Gradle 8.1; project is on 9.4.1).Testing
./gradlew checkJetifier→ "does not use any legacy support libraries… you can disable Jetifier".switch/caseonR.*resource IDs (verified acrossapp/src).renameApksForOssDebugstill runs and producesNekoBox-1.4.2-mod-12-<abi>.apkin both runs.Greptile Summary
This PR removes two deprecated
gradle.propertiesflags (android.enableJetifier=trueandandroid.nonFinalResIds=false) that AGP 10 drops and enables the Gradle configuration cache (org.gradle.configuration-cache=true), which has been stable since Gradle 8.1 and the project is on 9.4.1.android.enableJetifieris removed aftercheckJetifierconfirmed no legacyandroid.support.*artifacts are in use; omitting it adopts the AGP 9 default offalse.android.nonFinalResIds=falseis removed to adopt the AGP 9 default (true/non-final), which is safe because there are no Javaswitch/casestatements onR.*resource IDs anywhere in the project.RenameApkTaskinbuildSrcuses proper Gradle lazy APIs and was empirically verified to serialize and reuse correctly.Confidence Score: 5/5
Safe to merge — all three changes are removals or opt-ins to well-established defaults, and the custom build logic in RenameApkTask was verified to work correctly with the configuration cache.
The only file changed is gradle.properties, and each of the three modifications has been empirically tested: checkJetifier confirmed Jetifier was a no-op, a codebase-wide scan confirmed no Java switch/case on R.id constants, and a two-run configuration-cache test showed both cold-store and warm-reuse working end-to-end.
No files require special attention.
Important Files Changed
Reviews (1): Last reviewed commit: "Adopt AGP 9 defaults + enable Gradle con..." | Re-trigger Greptile