Skip to content
This repository was archived by the owner on May 11, 2026. It is now read-only.

Enable import of dashboads from $GF_DASHBOARDS_PATH#66

Open
akram wants to merge 1 commit into
hawkular:masterfrom
akram:patch-1
Open

Enable import of dashboads from $GF_DASHBOARDS_PATH#66
akram wants to merge 1 commit into
hawkular:masterfrom
akram:patch-1

Conversation

@akram

@akram akram commented Apr 20, 2017

Copy link
Copy Markdown

Uses the dashboards.json section, enables it and set the path of json dashboards to automatically be imported on startup

Uses the dashboards.json section, enables it and set the path of json dashboards to automatically be imported on startup
@jotak jotak self-requested a review April 24, 2017 07:43

@jotak jotak left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@garethahealy any other comment?

Comment thread docker/run.sh
--config=/etc/grafana/grafana.ini \
cfg:default.paths.data="$GF_PATHS_DATA" \
cfg:default.paths.logs="$GF_PATHS_LOGS" \
cfg:default.dashboards.json.enabled=GF_DASHBOARDS_ENABLED \

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"$" is missing on GF_DASHBOARDS_ENABLED

Comment thread docker/run.sh
: "${GF_PATHS_DATA:=/var/lib/grafana}"
: "${GF_PATHS_LOGS:=/var/log/grafana}"
: "${GF_PATHS_PLUGINS:=/var/lib/grafana/plugins}"
: "${GF_DASHBOARDS_ENABLED:=true}"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should keep "false" as the default, and override to true when wanted? docker run -e "GF_DASHBOARDS_ENABLED=true" -i -p 3000:3000 (etc.)

@garethahealy

Copy link
Copy Markdown
Contributor

Looks fine other than your minor comments @jotak

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants