Skip to content

Commit ac3dfed

Browse files
authored
Ensure fail option used with curl to catch errors
By default, curl returns a `0` exit code even in the case of 404 errors. This means that errors like the one in hazelcast/hazelcast-mono#7091 are tricky to spot. It would be better if we used the [`fail` option](https://curl.se/docs/manpage.html#--fail) to ensure the failure is visible.
1 parent c813b7e commit ac3dfed

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

.github/workflows/get-supported-node-versions.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ jobs:
2222
# - Currently supported
2323
# - That are LTS
2424
# - Within LTS date range (i.e. not future LTS)
25-
NODE_VERSIONS=$(curl --silent https://raw.githubusercontent.com/nodejs/Release/main/schedule.json | jq --compact-output '
25+
NODE_VERSIONS=$(curl --fail --silent https://raw.githubusercontent.com/nodejs/Release/main/schedule.json | jq --compact-output '
2626
def today: now | strftime("%Y-%m-%d");
2727
to_entries
2828
| map(select(.value.end > today and .value.lts != null and .value.lts < today))

0 commit comments

Comments
 (0)