Getting Ready for 5.6.0 Release (#1571)

* Set client version to 5.6.0
* Require Node.js 20 as the minimum. It's the currently minimum
manintend Node,js LTS
* Fixed leaks with some socket callbacks
* Use `clearTimeout` for `setTimeout` instead of `clearInterval`.

Author: yuce

Makefile

@@ -0,0 +1,14 @@
+.PHONY: build lint test test-all
+
+build:
+	npm run compile
+
+lint:
+	npm run lint
+
+test: build lint
+	npm test
+
+test-all: build lint
+	env HAZELCAST_ENTERPRISE_KEY=1 npm test
+

README.md

@@ -210,6 +210,6 @@ This command will only run the tests matching the pattern. The pattern can be a
 
 ## Copyright
 
-Copyright (c) 2008-2022, Hazelcast, Inc. All Rights Reserved.
+Copyright (c) 2008-2026, Hazelcast, Inc. All Rights Reserved.
 
 Visit [www.hazelcast.com](http://www.hazelcast.com) for more information.

package.json

@@ -1,6 +1,6 @@
 {
     "name": "hazelcast-client",
-    "version": "5.3.0",
+    "version": "5.6.0",
     "description": "Hazelcast - a real-time stream processing platform - Node.js Client",
     "main": "lib/index.js",
     "types": "lib/index.d.ts",
@@ -9,7 +9,7 @@
         "lib/**/*.d.ts"
     ],
     "dependencies": {
-        "@types/long": "4.0.0",
+        "@types/long": "4.0.2",
         "long": "4.0.0"
     },
     "devDependencies": {
@@ -23,9 +23,9 @@
         "eslint-plugin-mocha": "~9.0.0",
         "husky": "~6.0.0",
         "jsonschema": "~1.5.0",
-        "markdown-link-check": "~3.13.7",
+        "markdown-link-check": "^3.14.2",
         "markdownlint-cli": "~0.32.2",
-        "mocha": "~9.2.2",
+        "mocha": "^11.7.5",
         "mousse": "~0.3.1",
         "nyc": "~15.1.0",
         "path-exists-cli": "~2.0.0",
@@ -41,7 +41,7 @@
         "yargs": "~17.5.1"
     },
     "engines": {
-        "node": ">=10.4.0"
+        "node": ">=20.20.0"
     },
     "scripts": {
         "clean": "rimraf lib *.jar *.log *.xml coverage",

src/invocation/InvocationService.ts

@@ -684,6 +684,7 @@ export class InvocationService {
                 + invocation.request.getCorrelationId() + ') reached its deadline.', error));
             return true;
         }
+        return false;
     }
 
     private registerInvocation(invocation: Invocation): void {
@@ -703,7 +704,7 @@ export class InvocationService {
     deregisterInvocation(correlationId: number): void {
         this.pending.delete(correlationId);
     }
-    
+
     /**
      * Returns `true` if we need to check the urgent invocations, by
      * examining the local registry of the schema service.
@@ -743,7 +744,7 @@ export class InvocationService {
             + 'data and it is not safe to invoke it when the client is not '
             + 'yet initialized on the cluster');
         }
-        
+
         return null;
     }
 }

src/network/Connection.ts

@@ -62,6 +62,7 @@ export class PipelinedWriter extends Writer {
     private canWrite = true;
     // reusable buffer for coalescing
     private readonly coalesceBuf: Buffer;
+    private readonly drainListener: () => void;
 
     constructor(
         private readonly socket: net.Socket,
@@ -72,11 +73,13 @@ export class PipelinedWriter extends Writer {
         super();
         this.coalesceBuf = Buffer.allocUnsafe(threshold);
 
-        // write queued items on drain event
-        socket.on('drain', () => {
+        this.drainListener = () => {
             this.canWrite = true;
             this.schedule();
-        });
+        }
+
+        // write queued items on drain event
+        socket.on('drain', this.drainListener);
     }
 
     write(message: ClientMessage, resolver: DeferredPromise<void>): void {
@@ -94,6 +97,7 @@ export class PipelinedWriter extends Writer {
         }
         this.error = this.makeIOError(error);
         this.canWrite = false;
+        this.socket.off('drain', this.drainListener);
         // If we pass an error to destroy, an unhandled error will be thrown because we don't handle the error event
         // So we don't pass anything to the socket. It is internal anyway.
         this.socket.destroy();
@@ -214,6 +218,8 @@ export class DirectWriter extends Writer {
     }
 
     close(cause: Error): void {
+        // Remove all listeners from this emitter
+        this.removeAllListeners('write');
         this.socket.destroy();
     }
 }
@@ -351,6 +357,8 @@ export class Connection {
     private readonly writer: Writer;
     private readonly reader: ClientMessageReader;
     private readonly fragmentedMessageHandler: FragmentedClientMessageHandler;
+    private dataListener: ((buffer: Buffer) => void) | null = null;
+    private writeListener: (() => void) | null = null;
 
     constructor(
         private readonly connectionManager: ConnectionManager,
@@ -374,9 +382,10 @@ export class Connection {
         this.connectedServerVersion = BuildInfo.UNKNOWN_VERSION_ID;
         this.writer = enablePipelining ? new PipelinedWriter(this.socket, pipeliningThreshold, this.incrementBytesWrittenFn)
             : new DirectWriter(this.socket, this.incrementBytesWrittenFn);
-        this.writer.on('write', () => {
+        this.writeListener = () => {
             this.lastWriteTimeMillis = Date.now();
-        });
+        }
+        this.writer.on('write', this.writeListener);
         this.reader = new ClientMessageReader();
         this.fragmentedMessageHandler = new FragmentedClientMessageHandler(this.logger);
     }
@@ -437,11 +446,28 @@ export class Connection {
 
         this.logClose();
 
+        // Remove socket listeners before closing
+        this.removeListeners();
+
         this.writer.close(this.closedCause ? this.closedCause : new Error(reason ? reason : 'Connection closed'));
 
         this.connectionManager.onConnectionClose(this);
     }
 
+    /**
+     * Removes all registered listeners from the socket and writer.
+     */
+    private removeListeners(): void {
+        if (this.dataListener !== null) {
+            this.socket.off('data', this.dataListener);
+            this.dataListener = null;
+        }
+        if (this.writeListener !== null) {
+            this.writer.off('write', this.writeListener);
+            this.writeListener = null;
+        }
+    }
+
     isAlive(): boolean {
         return this.closedTime === 0;
     }
@@ -483,7 +509,7 @@ export class Connection {
      * @param callback
      */
     registerResponseCallback(callback: ClientMessageHandler): void {
-        this.socket.on('data', (buffer: Buffer) => {
+        this.dataListener = (buffer: Buffer) => {
             this.lastReadTimeMillis = Date.now();
             this.reader.append(buffer);
             let clientMessage = this.reader.read();
@@ -496,14 +522,15 @@ export class Connection {
                 clientMessage = this.reader.read();
             }
             this.incrementBytesReadFn(buffer.length);
-        });
+        }
+        this.socket.on('data', this.dataListener);
     }
 
     setClusterUuid(uuid: UUID): void {
         this.clusterUuid = uuid;
     }
 
-    getClusterUuid(): UUID { 
+    getClusterUuid(): UUID {
         return this.clusterUuid;
     }
 

src/network/ConnectionManager.ts

@@ -665,11 +665,11 @@ export class ConnectionManager extends EventEmitter implements MembershipListene
         }, this.connectionTimeoutMillis);
 
         socket.once('secureConnect', () => {
-            clearInterval(connectTimeoutTimer);
+            clearTimeout(connectTimeoutTimer);
             connectionResolver.resolve(socket);
         });
         socket.once('error', (err) => {
-            clearInterval(connectTimeoutTimer);
+            clearTimeout(connectTimeoutTimer);
             connectionResolver.reject(err);
         });