Merge branch 'master' into HZC-7235/change-cloud-url

atilsensalduz · web-flow · commit c7a8db5bdefb · 2025-11-10T16:32:02.000+03:00
diff --git a/.github/java-config.env b/.github/java-config.env
@@ -0,0 +1,2 @@
+JAVA_VERSION=17
+JAVA_DISTRIBUTION=temurin
diff --git a/.github/workflows/code_quality.yml b/.github/workflows/code_quality.yml
@@ -8,15 +8,19 @@ on:
     pull_request:
 
 jobs:
+    node-versions:
+      uses: ./.github/workflows/get-supported-node-versions.yml
+
     check-code-quality:
         name: Check code quality
         runs-on: ubuntu-latest
+        needs: node-versions
 
         steps:
             - name: Setup Node.js
               uses: actions/setup-node@v4
               with:
-                  node-version: 12
+                  node-version: ${{ needs.node-versions.outputs.default-version }}
             - name: Checkout code
               uses: actions/checkout@v4
             - name: Install dependencies
diff --git a/.github/workflows/code_sample_checker.yml b/.github/workflows/code_sample_checker.yml
@@ -2,29 +2,46 @@ name: Code sample checker
 on: pull_request
 
 jobs:
+    node-versions:
+      uses: ./.github/workflows/get-supported-node-versions.yml
+
     test-code-samples:
         name: Check code samples
         runs-on: ${{matrix.os}}
+        needs: node-versions
 
         strategy:
             matrix:
                 os: [ ubuntu-latest, windows-latest ]
 
         steps:
+            - name: Checkout code
+              uses: actions/checkout@v4
+            - name: Read Java Config
+              shell: bash
+              run: cat .github/java-config.env >> $GITHUB_ENV
             - name: Setup Java
               uses: actions/setup-java@v4
               with:
-                  java-version: 17
+                java-version: ${{ env.JAVA_VERSION }}
+                distribution: ${{ env.JAVA_DISTRIBUTION }}
             - name: Setup Node.js
               uses: actions/setup-node@v4
               with:
-                  node-version: 10
-            - name: Checkout code
-              uses: actions/checkout@v4
+                  node-version: ${{ needs.node-versions.outputs.default-version }}
             - name: Install dependencies and compile client
               run: |
                   npm install
                   npm run compile
             - name: Check code samples
               run: |
                   npm run check-code-samples
+
+            - name: Upload remote controller logs if test run fails
+              uses: actions/upload-artifact@v4
+              if: failure()
+              with:
+                  name: rc-logs-${{ matrix.os }}
+                  path: |
+                      rc_stderr.log
+                      rc_stdout.log
diff --git a/.github/workflows/coverage_runner.yml b/.github/workflows/coverage_runner.yml
@@ -25,28 +25,24 @@ jobs:
         uses: hazelcast/hazelcast-tpm/membership@main
         with:
           organization-name: 'hazelcast'
-          member-name: ${{ github.event.pull_request.head.repo.owner.login }}
+          member-name: ${{ github.actor }}
           token: ${{ secrets.PAT }}
 
+  node-versions:
+    uses: ./.github/workflows/get-supported-node-versions.yml
+
   run-tests:
       name: Run Tests on (${{ matrix.os }})
-      needs: [check_for_membership]
+      needs:
+        - check_for_membership
+        - node-versions
       if: github.event_name == 'push' || needs.check_for_membership.outputs.check-result == 'true' || github.event_name == 'workflow_dispatch'
       runs-on: ${{ matrix.os }}
       strategy:
           matrix:
               os: [ ubuntu-latest, windows-latest ]
 
       steps:
-          - name: Setup Java
-            uses: actions/setup-java@v1
-            with:
-                java-version: 17
-          - name: Setup Node.js
-            uses: actions/setup-node@v4
-            with:
-                node-version: 10
-
           - name: Checkout code for PR
             if: github.event_name == 'pull_request_target'
             uses: actions/checkout@v4
@@ -63,6 +59,19 @@ jobs:
             with:
               ref: refs/pull/${{ github.event.inputs.pr_number }}/merge
 
+          - name: Read Java Config
+            shell: bash
+            run: cat .github/java-config.env >> $GITHUB_ENV
+          - name: Setup Java
+            uses: actions/setup-java@v4
+            with:
+              java-version: ${{ env.JAVA_VERSION }}
+              distribution: ${{ env.JAVA_DISTRIBUTION }}
+          - name: Setup Node.js
+            uses: actions/setup-node@v4
+            with:
+                node-version: ${{ needs.node-versions.outputs.default-version }}
+
           - name: Checkout to test artifacts
             uses: actions/checkout@v4
             with:
@@ -73,6 +82,7 @@ jobs:
           - name: Copy certificates JAR to destination with the appropriate name
             run: |
               cp ${{ github.workspace }}/certs/certs.jar ${{ github.workspace }}/certs.jar
+              unzip -p ${{ github.workspace }}/certs.jar com/hazelcast/nio/ssl/letsencrypt.jks > test/integration/backward_compatible/parallel/ssl/keystore.jks
 
           - name: Install dependencies and compile client
             run: |
@@ -87,23 +97,29 @@ jobs:
 
           - name: Publish results to Codecov for PR coming from hazelcast organization
             if: ${{ matrix.os == 'ubuntu-latest' && github.event_name == 'pull_request_target' }}
-            uses: codecov/codecov-action@v3
+            uses: codecov/codecov-action@v5
             with:
+              token: ${{ secrets.CODECOV_TOKEN }}
               files: coverage/lcov.info
               override_pr: ${{ github.event.pull_request.number }}
+              fail_ci_if_error: true
 
           - name: Publish results to Codecov for Push
             if: ${{ matrix.os == 'ubuntu-latest' && github.event_name == 'push' }}
-            uses: codecov/codecov-action@v3
+            uses: codecov/codecov-action@v5
             with:
+              token: ${{ secrets.CODECOV_TOKEN }}
               files: coverage/lcov.info
+              fail_ci_if_error: true
 
           - name: Publish result to Codecov for PR coming from community
             if: ${{ matrix.os == 'ubuntu-latest' && github.event_name == 'workflow_dispatch' }}
-            uses: codecov/codecov-action@v3
+            uses: codecov/codecov-action@v5
             with:
+              token: ${{ secrets.CODECOV_TOKEN }}
               files: coverage/lcov.info
               override_pr: ${{ github.event.inputs.pr_number }}
+              fail_ci_if_error: true
 
           - name: Upload remote controller logs if test run fails
             uses: actions/upload-artifact@v4
diff --git a/.github/workflows/get-supported-node-versions.yml b/.github/workflows/get-supported-node-versions.yml
@@ -0,0 +1,35 @@
+name: Get supported Node.js versions
+
+on:
+  workflow_call:
+    outputs:
+      node-versions:
+        value: ${{ jobs.get-supported-node-versions.outputs.node-versions }}
+      default-version:
+        value: ${{ jobs.get-supported-node-versions.outputs.default-version }}
+
+jobs:
+  get-supported-node-versions:
+    runs-on: ubuntu-latest
+    outputs:
+      node-versions: ${{ steps.get_versions.outputs.node-versions }}
+      default-version: ${{ steps.get_versions.outputs.default-version }}
+    steps:
+      - name: Get supported Node.js versions
+        id: get_versions
+        run: |
+          # Look for versions that are:
+          # - Currently supported
+          # - That are LTS
+          # - Within LTS date range (i.e. not future LTS)
+          NODE_VERSIONS=$(curl --silent https://raw.githubusercontent.com/nodejs/Release/main/schedule.json | jq --compact-output '
+              def today: now | strftime("%Y-%m-%d");
+              to_entries
+              | map(select(.value.end > today and .value.lts != null and .value.lts < today))
+              | [.[0].key, .[-1].key]
+              | unique
+          ')
+
+          echo "node-versions=${NODE_VERSIONS}" >> ${GITHUB_OUTPUT}
+          # Default to using the newest version
+          echo "default-version=$(jq -r '.[1]' <<< ${NODE_VERSIONS})" >> ${GITHUB_OUTPUT}
diff --git a/.github/workflows/markdown_link_checker.yml b/.github/workflows/markdown_link_checker.yml
@@ -5,6 +5,4 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v4
-    - uses: gaurav-nelson/github-action-markdown-link-check@v1
-      with:
-        use-quiet-mode: 'yes'
+    - uses: ruzickap/action-my-markdown-link-checker@v1
diff --git a/.github/workflows/nightly_runner_maintenance.yml b/.github/workflows/nightly_runner_maintenance.yml
@@ -4,18 +4,22 @@ on:
     schedule:
         - cron: '0 2 */2 * *'
 jobs:
+    node-versions:
+      uses: ./.github/workflows/get-supported-node-versions.yml
+
     run-tests:
         runs-on: ${{ matrix.os }}
+        needs: node-versions
         name: Run tests of branch ${{ matrix.branch }} on ${{ matrix.os }} with Node ${{ matrix.nodejs_version }}
         strategy:
             matrix:
                 branch: [ 5.0.x, 4.2.x, 4.1.x, 4.0.x ]
                 os: [ ubuntu-latest, windows-latest ]
-                nodejs_version: [ 10, 18 ]
+                nodejs_version: ${{ fromJSON(needs.node-versions.outputs.node-versions) }}
             fail-fast: false
         steps:
             - name: Setup Java
-              uses: actions/setup-java@v2
+              uses: actions/setup-java@v4
               with:
                   java-version: 8
                   distribution: temurin
diff --git a/.github/workflows/nightly_runner_master.yml b/.github/workflows/nightly_runner_master.yml
@@ -4,26 +4,33 @@ on:
     schedule:
         - cron: '0 2 * * *'
 jobs:
+    node-versions:
+      uses: ./.github/workflows/get-supported-node-versions.yml
+
     run-tests:
         runs-on: ${{ matrix.os }}
+        needs: node-versions
         name: Run tests of master on ${{ matrix.os }} with Node ${{ matrix.nodejs_version }}
         strategy:
             matrix:
                 os: [ ubuntu-latest, windows-latest ]
-                nodejs_version: [ 10, 18 ]
+                nodejs_version: ${{ fromJSON(needs.node-versions.outputs.node-versions) }}
             fail-fast: false
         steps:
+            - name: Checkout code
+              uses: actions/checkout@v4
+            - name: Read Java Config
+              shell: bash
+              run: cat .github/java-config.env >> $GITHUB_ENV
             - name: Setup Java
-              uses: actions/setup-java@v2
+              uses: actions/setup-java@v4
               with:
-                  java-version: 17
-                  distribution: temurin
+                java-version: ${{ env.JAVA_VERSION }}
+                distribution: ${{ env.JAVA_DISTRIBUTION }}
             - name: Setup Node.js
               uses: actions/setup-node@v4
               with:
                   node-version: ${{ matrix.nodejs_version }}
-            - name: Checkout code
-              uses: actions/checkout@v4
             - name: Checkout to test artifacts
               uses: actions/checkout@v4
               with:
@@ -34,6 +41,7 @@ jobs:
             - name: Copy certificates JAR to destination with the appropriate name
               run: |
                 cp ${{ github.workspace }}/certs/certs.jar ${{ github.workspace }}/certs.jar
+                unzip -p ${{ github.workspace }}/certs.jar com/hazelcast/nio/ssl/letsencrypt.jks > test/integration/backward_compatible/parallel/ssl/keystore.jks
             - name: Install dependencies and compile client
               run: |
                   npm install
diff --git a/.husky/pre-commit b/.husky/pre-commit
@@ -1,6 +1,9 @@
 #!/bin/sh
 . "$(dirname "$0")/_/husky.sh"
 
-npm run compile
-npm run lint
-npm run validate-user-code
+# See https://github.com/typicode/husky/issues/1072#issuecomment-1784006332
+npm_exec=$([[ $OS == "Windows_NT" ]] && echo "npm.cmd" || echo "npm")
+
+"${npm_exec}" run compile
+"${npm_exec}" run lint
+"${npm_exec}" run validate-user-code
diff --git a/DOCUMENTATION.md b/DOCUMENTATION.md
@@ -39,7 +39,7 @@
   * [5.3. Enabling Redo Operation](#53-enabling-redo-operation)
   * [5.4. Setting Connection Timeout](#54-setting-connection-timeout)
   * [5.5. Enabling Client TLS/SSL](#55-enabling-client-tlsssl)
-  * [5.6. Enabling Hazelcast Viridian Discovery](#56-enabling-hazelcast-viridian-discovery)
+  * [5.6. Enabling Hazelcast Cloud Discovery](#56-enabling-hazelcast-cloud-discovery)
   * [5.7. Configuring Backup Acknowledgment](#57-configuring-backup-acknowledgment)
   * [5.8. External Client Public Address Discovery](#58-external-client-public-address-discovery)
 * [6. Client Connection Strategy](#6-client-connection-strategy)
@@ -699,19 +699,19 @@ When Hazelcast Node.js client serializes an object:
 
 4. If the above check fails, then it checks if it is an instance of one of the default types (see above default types).
 
-5. If the above check fails, then it looks for a user-specified [Custom Serialization](#43-custom-serialization).
+5. If the above check fails, then it looks for a user-specified [Custom Serialization](#44-custom-serialization).
 
-6. If the above check fails, it will use the registered [Global Serialization](#44-global-serialization) if one exists.
+6. If the above check fails, it will use the registered [Global Serialization](#45-global-serialization) if one exists.
 
 7. If the above check fails, then the Node.js client uses `JSON Serialization` by default.
 
 However, `JSON Serialization` may not be the best way of serialization in terms of performance and interoperability between
 the clients in different languages. If you want the serialization to work faster or you use the clients in different languages,
 Hazelcast offers its own native serialization methods, such as
-[`IdentifiedDataSerializable` Serialization](#41-identifieddataserializable-serialization) and
-[`Portable` Serialization](#42-portable-serialization).
+[`IdentifiedDataSerializable` Serialization](#42-identifieddataserializable-serialization) and
+[`Portable` Serialization](#43-portable-serialization).
 
-Or, if you want to use your own serialization method, you can use [Custom Serialization](#43-custom-serialization).
+Or, if you want to use your own serialization method, you can use [Custom Serialization](#44-custom-serialization).
 
 > **NOTE: Hazelcast Node.js client is a TypeScript-based project but JavaScript does not have interfaces. Therefore, some
 > interfaces are given to the user by using the TypeScript files that have `.ts` extension. In this guide, implementing an
@@ -1431,10 +1431,10 @@ authentication feature which allows the Node.js clients also to have their priva
 to have their certificate authorities so that the members can know which clients they can trust. See the
 [Mutual Authentication section](#913-mutual-authentication).
 
-## 5.6. Enabling Hazelcast Viridian Discovery
+## 5.6. Enabling Hazelcast Cloud Discovery
 
 Hazelcast Node.js client can discover and connect to Hazelcast clusters running on
-[Hazelcast Viridian](https://viridian.hazelcast.com/). For this, provide authentication information as `clusterName` and enable cloud
+[Hazelcast Cloud](https://cloud.hazelcast.com/). For this, provide authentication information as `clusterName` and enable cloud
 discovery by setting your `discoveryToken` as shown below.
 
 ```javascript
@@ -3567,7 +3567,7 @@ results of your query are ready, they are parsed from JSON strings and returned
 
 For the purposes of your application, you may want to get rid of the parsing and just work with the raw JSON strings using
 `HazelcastJsonValue` objects. Then, you can configure your client to do so as described in the
-[JSON Serialization](#45-json-serialization) section.
+[JSON Serialization](#46-json-serialization) section.
 
 ```javascript
 const client = await Client.newHazelcastClient({
diff --git a/README.md b/README.md
@@ -138,7 +138,7 @@ Refer to [the documentation](DOCUMENTATION.md) to learn more about supported con
 * Cluster-wide unique ID generator, called **FlakeIdGenerator**
 * Distributed, CRDT based counter, called **PNCounter**
 * Distributed concurrency primitives from CP Subsystem such as **FencedLock**, **Semaphore**, **AtomicLong**
-* Integration with [Hazelcast Viridian](https://viridian.hazelcast.com/)
+* Integration with [Hazelcast Cloud](https://cloud.hazelcast.com/)
 * Support for serverless and traditional web service architectures with **Unisocket** and **Smart** operation modes
 * Ability to listen client lifecycle, cluster state and distributed data structure events
 * and [many more](https://hazelcast.com/clients/node-js/#client-features).
diff --git a/package.json b/package.json
@@ -22,8 +22,8 @@
         "eslint": "~8.28.0",
         "eslint-plugin-mocha": "~9.0.0",
         "husky": "~6.0.0",
-        "jsonschema": "~1.4.0",
-        "markdown-link-check": "~3.10.2",
+        "jsonschema": "~1.5.0",
+        "markdown-link-check": "~3.13.7",
         "markdownlint-cli": "~0.32.2",
         "mocha": "~9.2.2",
         "mousse": "~0.3.1",
diff --git a/scripts/download-rc.js b/scripts/download-rc.js
diff --git a/scripts/test-runner.js b/scripts/test-runner.js

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+JAVA_VERSION=17`
	`2`	`+JAVA_DISTRIBUTION=temurin`