[HZ-5339] Use RCD as the test runner

[yuce]

The RC runner for Nodejs needs to be updated to download test artifacts.
Instead of that, RCD can be used to to start the RC.

• Use RCD as the test runner
• Remove husky precommit hook

[JackPGreen]

The RC runner for Nodejs needs to be updated to download test artifacts. Instead of that, RCD can be used to to start the RC.

• Use RCD as the test runner
• Remove husky precommit hook

Does this mean we can remove download-rc.js?

• Remove husky precommit hook

What's wrong with it?

[JackPGreen]

[] redundant.
Also this upgrades the version from 5.4 -> 5.6 which is good but probably not required for this change.

[yuce]

If I remove the [] I get a lint error. The matrix schema seems to require it.
We'll need 5.6.0 for the release of the client.

[JackPGreen]

If I remove the [] I get a lint error.

Ah - I think that's because it's a matrix.
My preference is that:

hz_version:
   - 5.6.0

Is more readable in this case, but that's just a nit.

We'll need 5.6.0 for the release of the client.

It would be nice if that was in the PR body or a seperate PR just in case someones tries to figure out why the behaviour changed in this PR and it appears to be just RCD.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.47%. Comparing base (c641a1e) to head (9b4f2d6).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1569   +/-   ##
=======================================
  Coverage   93.46%   93.47%           
=======================================
  Files         466      466           
  Lines       16628    16628           
  Branches     1350     1350           
=======================================
+ Hits        15542    15543    +1     
  Misses        792      792           
+ Partials      294      293    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[yuce]

I removed download-rc.js at: 790d24c

Remove husky precommit hook

What's wrong with it?

There's a syntax error in the hook, that alerted me about this hook when I tried to commit.
It's not necessary, and it would be better to enforce the style as a separate step like in the python client.

[yuce]

The tests pass with running the workflows from the branch:

• https://github.com/hazelcast/hazelcast-nodejs-client/actions/runs/21401308715/job/61612859484
• https://github.com/hazelcast/hazelcast-nodejs-client/actions/runs/21401308715/job/61612859636

[JackPGreen]

Should this file be included? I thought it's resolved from the certs JAR?

[yuce]

That's for CI. People cloning the repo should still be able to run the tests.

[ihsandemir]

is this a reliable check? some downloads last longer.

[JackPGreen]

It's not the perfect solution but it's what were already using here - https://github.com/hazelcast/client-compatibility-suites/blob/9638ad773c89d8059a20d165d0c7101d9a95ac62/.github/workflows/python_client_compatibility.yaml#L126-L134