Skip to content

[HZ-5341] Fixed 1567#1570

Merged
yuce merged 1 commit intomasterfrom
fix/1567
Jan 28, 2026
Merged

[HZ-5341] Fixed 1567#1570
yuce merged 1 commit intomasterfrom
fix/1567

Conversation

@yuce
Copy link
Copy Markdown
Contributor

@yuce yuce commented Jan 28, 2026

There's a bug in compact writer that causes writing unsigned integers bigger than 32767 using buffer.write16BE method which is out of range.

This PR fixes #1567

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.45%. Comparing base (2806414) to head (14909cf).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1570      +/-   ##
==========================================
+ Coverage   93.43%   93.45%   +0.01%     
==========================================
  Files         466      466              
  Lines       16628    16629       +1     
  Branches     1350     1351       +1     
==========================================
+ Hits        15537    15541       +4     
+ Misses        799      795       -4     
- Partials      292      293       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yuce yuce requested review from emreyigit and ihsandemir January 28, 2026 08:41
Comment thread src/serialization/compact/DefaultCompactWriter.ts
@yuce yuce changed the title Fixed 1567 [HZ-5341] Fixed 1567 Jan 28, 2026
@yuce yuce merged commit 7ca2e69 into master Jan 28, 2026
16 checks passed
@yuce yuce deleted the fix/1567 branch January 28, 2026 12:43
@yuce yuce added this to the 5.6.0 milestone Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ERR_OUT_OF_RANGE]: The value of "value" is out of range. It must be >= -32768 and <= 32767. Received 32775

2 participants