Update nighlies to work with RCD#1575
Conversation
yuce
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1575 +/- ##
==========================================
+ Coverage 93.43% 93.47% +0.03%
==========================================
Files 466 466
Lines 16644 16644
Branches 1353 1353
==========================================
+ Hits 15552 15558 +6
+ Misses 796 792 -4
+ Partials 296 294 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| echo "RCD Log:" | ||
| cat rcd-stdout.log | ||
| cat rcd-stderr.log | ||
| npm run coverage |
There was a problem hiding this comment.
We only capture the log output for Windows, not Linux.
I'm aware this is copy-pasted from the Python client so it's non-blocking feedback.
It would be nice if this was shared.
There was a problem hiding this comment.
I agree, we have to refactor the workflows.
RCD logs are sent to atdout/stderr on Linux, but they are redirected to a file in Windows.
Didn't find a good way of redirecting to stdout/stderr on Windows while I was coding the workflow.
So I had to cat them to see its output.
| ./rcd-ubuntu-latest -version $HZ_VERSION -no-simple-server & | ||
| # wait for a bit for RCD to download artifacts | ||
| sleep 10 | ||
| npm run coverage |
There was a problem hiding this comment.
Could we move npm run coverage to a separate step as it's in both Run all tests blocks?
There was a problem hiding this comment.
Having it in a separate step didn't work before.
I think RCD process is terminated when the next step starts to run.
There was a problem hiding this comment.
Nit - maybe add a comment to that effect?
| needs: | ||
| - node-versions |
There was a problem hiding this comment.
| needs: | |
| - node-versions | |
| needs: node-versions |
nit
2 participants
Passing test run: https://github.com/hazelcast/hazelcast-nodejs-client/actions/runs/21625136673/job/62323299300