[HZ-5348] Sort fields in compact schema by name#1577
Merged
yuce merged 1 commit intohazelcast:masterfrom Feb 9, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1577 +/- ##
==========================================
- Coverage 93.45% 93.42% -0.03%
==========================================
Files 466 466
Lines 16644 16645 +1
Branches 1353 1353
==========================================
- Hits 15554 15550 -4
- Misses 797 800 +3
- Partials 293 295 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yuce
changed the title
emreyigit
reviewed
Feb 9, 2026
| for (const field of fields) { | ||
| this.fieldDefinitionMap = new Map<string, FieldDescriptor>(); | ||
| for (const field of this.fields) { | ||
| // map entries are sorted by insertion order |
Member
There was a problem hiding this comment.
Aren't fields already sorted by field name?
Contributor
Author
There was a problem hiding this comment.
The fields are sorted by name in the previous line.
This is just a comment to clarify that the order will be preserved in this.fieldDefinitionMap, since Javascript guarantees that for maps.
For example in Go, that wouldn't work, since the map entries are accessed randomly.
emreyigit
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1576