Skip to content

Commit 132494d

Browse files
authored
Skip VC tests in incompatible versions (#776)
1 parent 00c7473 commit 132494d

4 files changed

Lines changed: 12 additions & 2 deletions

File tree

docs/getting_started.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ Requirements
1515
- Windows, Linux/UNIX or Mac OS X
1616
- Python 3.11 or newer
1717
- Hazelcast 5.0 or newer
18-
- `Supported Java virtual machine <https://docs.hazelcast.com/hazelcast/latest/deploy/versioning-compatibility#supported-java-virtual-machines>`__
18+
- `Supported Java Development Kit (JDK) <https://docs.hazelcast.com/hazelcast/latest/deploy/versioning-compatibility#java-development-kits-jdks>`__
1919
- Latest Hazelcast Python client
2020

2121
Working with Hazelcast Clusters

docs/getting_started_asyncio.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ Requirements
1414
- Windows, Linux, macOS
1515
- Python 3.11 or newer
1616
- Hazelcast 5.6 or newer
17-
- `Supported Java virtual machine <https://docs.hazelcast.com/hazelcast/latest/deploy/versioning-compatibility#supported-java-virtual-machines>`__
17+
- `Supported Java Development Kit (JDK) <https://docs.hazelcast.com/hazelcast/latest/deploy/versioning-compatibility#java-development-kits-jdks>`__
1818
- Latest Hazelcast Python client
1919

2020
Working with Hazelcast Clusters

tests/integration/asyncio/proxy/vector_collection_test.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -203,6 +203,7 @@ async def test_backup_count_min_value_pass(self):
203203

204204
async def test_backup_count_more_than_max_value_fail(self):
205205
skip_if_server_version_older_than(self, self.client, "5.6.0")
206+
skip_if_client_version_older_than(self, "5.6.0")
206207
name = random_string()
207208
# check that the parameter is used by ensuring that it is validated on server side
208209
# there is no simple way to check number of backups
@@ -216,6 +217,7 @@ async def test_backup_count_more_than_max_value_fail(self):
216217

217218
async def test_backup_count_less_than_min_value_fail(self):
218219
skip_if_server_version_older_than(self, self.client, "5.6.0")
220+
skip_if_client_version_older_than(self, "5.6.0")
219221
name = random_string()
220222
with self.assertRaises(hazelcast.errors.IllegalArgumentError):
221223
await self.client.create_vector_collection_config(
@@ -243,6 +245,7 @@ async def test_async_backup_count_min_value_pass(self):
243245

244246
async def test_async_backup_count_more_than_max_value_fail(self):
245247
skip_if_server_version_older_than(self, self.client, "5.6.0")
248+
skip_if_client_version_older_than(self, "5.6.0")
246249
name = random_string()
247250
# check that the parameter is used by ensuring that it is validated on server side
248251
# there is no simple way to check number of backups
@@ -256,6 +259,7 @@ async def test_async_backup_count_more_than_max_value_fail(self):
256259

257260
async def test_async_backup_count_less_than_min_value_fail(self):
258261
skip_if_server_version_older_than(self, self.client, "5.6.0")
262+
skip_if_client_version_older_than(self, "5.6.0")
259263
name = random_string()
260264
with self.assertRaises(hazelcast.errors.IllegalArgumentError):
261265
await self.client.create_vector_collection_config(
@@ -266,6 +270,7 @@ async def test_async_backup_count_less_than_min_value_fail(self):
266270

267271
async def test_sync_and_async_backup_count_more_than_max_value_fail(self):
268272
skip_if_server_version_older_than(self, self.client, "5.6.0")
273+
skip_if_client_version_older_than(self, "5.6.0")
269274
name = random_string()
270275
with self.assertRaises(hazelcast.errors.IllegalArgumentError):
271276
await self.client.create_vector_collection_config(

tests/integration/backward_compatible/proxy/vector_collection_test.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -200,6 +200,7 @@ def test_backup_count_min_value_pass(self):
200200

201201
def test_backup_count_more_than_max_value_fail(self):
202202
skip_if_server_version_older_than(self, self.client, "5.6.0")
203+
skip_if_client_version_older_than(self, "5.6.0")
203204
name = random_string()
204205
# check that the parameter is used by ensuring that it is validated on server side
205206
# there is no simple way to check number of backups
@@ -213,6 +214,7 @@ def test_backup_count_more_than_max_value_fail(self):
213214

214215
def test_backup_count_less_than_min_value_fail(self):
215216
skip_if_server_version_older_than(self, self.client, "5.6.0")
217+
skip_if_client_version_older_than(self, "5.6.0")
216218
name = random_string()
217219
with self.assertRaises(hazelcast.errors.IllegalArgumentError):
218220
self.client.create_vector_collection_config(
@@ -240,6 +242,7 @@ def test_async_backup_count_min_value_pass(self):
240242

241243
def test_async_backup_count_more_than_max_value_fail(self):
242244
skip_if_server_version_older_than(self, self.client, "5.6.0")
245+
skip_if_client_version_older_than(self, "5.6.0")
243246
name = random_string()
244247
# check that the parameter is used by ensuring that it is validated on server side
245248
# there is no simple way to check number of backups
@@ -253,6 +256,7 @@ def test_async_backup_count_more_than_max_value_fail(self):
253256

254257
def test_async_backup_count_less_than_min_value_fail(self):
255258
skip_if_server_version_older_than(self, self.client, "5.6.0")
259+
skip_if_client_version_older_than(self, "5.6.0")
256260
name = random_string()
257261
with self.assertRaises(hazelcast.errors.IllegalArgumentError):
258262
self.client.create_vector_collection_config(
@@ -263,6 +267,7 @@ def test_async_backup_count_less_than_min_value_fail(self):
263267

264268
def test_sync_and_async_backup_count_more_than_max_value_fail(self):
265269
skip_if_server_version_older_than(self, self.client, "5.6.0")
270+
skip_if_client_version_older_than(self, "5.6.0")
266271
name = random_string()
267272
with self.assertRaises(hazelcast.errors.IllegalArgumentError):
268273
self.client.create_vector_collection_config(

0 commit comments

Comments
 (0)