fix: move resolution into inline spec and remove subtype lookup

Author: sejalpunwatkar

src/hdmf/validate/validator.py

@@ -498,21 +498,6 @@ def validate(self, **kwargs):
                     except Exception:
                         pass
 
-                if not found and dt is not None:
-                    try:
-                        for candidate_dt, v in self.vmap._ValidatorMap__validators.items():
-                            if candidate_dt == dt:
-                                continue
-                            if hasattr(v, "_BaseStorageValidator__attribute_validators"):
-                                candidate_hierarchy = self.vmap.namespace.get_hierarchy(candidate_dt)
-                                if dt in candidate_hierarchy:
-                                    dt_attrs = set(v._BaseStorageValidator__attribute_validators.keys())
-                                    if builder_attr in dt_attrs:
-                                        found = True
-                                        break
-                    except Exception:
-                        pass
-
                 if not found:
                     ret.append(ExtraFieldWarning(
                     self.get_spec_loc(self.spec),

tests/unit/validator_tests/test_validate.py

@@ -2064,21 +2064,20 @@ def getSpecs(self):
                 AttributeSpec(name='resolution', dtype='float', doc='extra attribute')
             ]
         )
-        return (
-            base_spec,
-            ext_spec,
-            GroupSpec(
-                doc='A group containing the base type',
-                data_type_def='GroupWithBase',
-                datasets=[
-                    DatasetSpec(
-                        name='data_column',
-                        doc='a dataset of base type',
-                        data_type_inc='BaseType'
-                    )
-                ]
-            ),
+        group_dataset_spec = DatasetSpec(
+            name='data_column',
+            doc='a dataset of base type',
+            data_type_inc='BaseType',
+            attributes=[
+                AttributeSpec(name='resolution', dtype='float', doc='extra attribute')
+            ]
+        )
+        group_spec = GroupSpec(
+            doc='A group containing the base type',
+            data_type_def='GroupWithBase',
+            datasets=[group_dataset_spec]
         )
+        return (base_spec, ext_spec, group_spec)
 
     def test_attribute_intersection_no_warning(self):
         """Test that 'resolution' triggers NO warning because ext_spec knows it."""