|
| 1 | +package handlers_test |
| 2 | + |
| 3 | +import ( |
| 4 | + "context" |
| 5 | + "encoding/json" |
| 6 | + "io" |
| 7 | + "net/http" |
| 8 | + "net/http/httptest" |
| 9 | + "testing" |
| 10 | + |
| 11 | + "github.com/hdresearch/vers-cli/internal/handlers" |
| 12 | +) |
| 13 | + |
| 14 | +// TestHandleRunCommit_CommitIDPath verifies that when IsRef is false, the |
| 15 | +// request body places the argument under "commit_id" (no "ref" key). |
| 16 | +// This is the default behavior — any existing callers must not regress. |
| 17 | +func TestHandleRunCommit_CommitIDPath(t *testing.T) { |
| 18 | + var receivedBody map[string]interface{} |
| 19 | + server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { |
| 20 | + if r.URL.Path != "/api/v1/vm/from_commit" { |
| 21 | + t.Errorf("unexpected path: %s", r.URL.Path) |
| 22 | + } |
| 23 | + if r.Method != http.MethodPost { |
| 24 | + t.Errorf("expected POST, got %s", r.Method) |
| 25 | + } |
| 26 | + body, _ := io.ReadAll(r.Body) |
| 27 | + json.Unmarshal(body, &receivedBody) |
| 28 | + |
| 29 | + w.Header().Set("Content-Type", "application/json") |
| 30 | + w.WriteHeader(http.StatusOK) |
| 31 | + w.Write([]byte(`{"vm_id": "vm-uuid-1"}`)) |
| 32 | + })) |
| 33 | + defer server.Close() |
| 34 | + |
| 35 | + a := testApp(server.URL) |
| 36 | + res, err := handlers.HandleRunCommit(context.Background(), a, handlers.RunCommitReq{ |
| 37 | + CommitKey: "abc-123", |
| 38 | + IsRef: false, |
| 39 | + }) |
| 40 | + if err != nil { |
| 41 | + t.Fatalf("unexpected error: %v", err) |
| 42 | + } |
| 43 | + if res.RootVmID != "vm-uuid-1" { |
| 44 | + t.Errorf("expected VM ID vm-uuid-1, got %s", res.RootVmID) |
| 45 | + } |
| 46 | + if res.CommitKey != "abc-123" { |
| 47 | + t.Errorf("expected CommitKey abc-123, got %s", res.CommitKey) |
| 48 | + } |
| 49 | + |
| 50 | + // The SDK flattens the vm_from_commit_request union into the top-level |
| 51 | + // request body (MarshalJSON on VmRestoreFromCommitParams inlines it). |
| 52 | + if receivedBody["commit_id"] != "abc-123" { |
| 53 | + t.Errorf("expected commit_id=abc-123, got %v", receivedBody["commit_id"]) |
| 54 | + } |
| 55 | + if _, refPresent := receivedBody["ref"]; refPresent { |
| 56 | + t.Errorf("expected no 'ref' key when IsRef=false, got: %v", receivedBody) |
| 57 | + } |
| 58 | +} |
| 59 | + |
| 60 | +// TestHandleRunCommit_RefPath verifies that when IsRef is true, the request |
| 61 | +// body uses "ref" instead of "commit_id". This is the new behavior added |
| 62 | +// by the --ref flag. |
| 63 | +func TestHandleRunCommit_RefPath(t *testing.T) { |
| 64 | + var receivedBody map[string]interface{} |
| 65 | + server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { |
| 66 | + if r.URL.Path != "/api/v1/vm/from_commit" { |
| 67 | + t.Errorf("unexpected path: %s", r.URL.Path) |
| 68 | + } |
| 69 | + if r.Method != http.MethodPost { |
| 70 | + t.Errorf("expected POST, got %s", r.Method) |
| 71 | + } |
| 72 | + body, _ := io.ReadAll(r.Body) |
| 73 | + json.Unmarshal(body, &receivedBody) |
| 74 | + |
| 75 | + w.Header().Set("Content-Type", "application/json") |
| 76 | + w.WriteHeader(http.StatusOK) |
| 77 | + w.Write([]byte(`{"vm_id": "vm-uuid-2"}`)) |
| 78 | + })) |
| 79 | + defer server.Close() |
| 80 | + |
| 81 | + a := testApp(server.URL) |
| 82 | + res, err := handlers.HandleRunCommit(context.Background(), a, handlers.RunCommitReq{ |
| 83 | + CommitKey: "my-app:latest", |
| 84 | + IsRef: true, |
| 85 | + }) |
| 86 | + if err != nil { |
| 87 | + t.Fatalf("unexpected error: %v", err) |
| 88 | + } |
| 89 | + if res.RootVmID != "vm-uuid-2" { |
| 90 | + t.Errorf("expected VM ID vm-uuid-2, got %s", res.RootVmID) |
| 91 | + } |
| 92 | + if res.CommitKey != "my-app:latest" { |
| 93 | + t.Errorf("expected CommitKey my-app:latest, got %s", res.CommitKey) |
| 94 | + } |
| 95 | + |
| 96 | + // The SDK flattens the vm_from_commit_request union into the top-level |
| 97 | + // request body (MarshalJSON on VmRestoreFromCommitParams inlines it). |
| 98 | + if receivedBody["ref"] != "my-app:latest" { |
| 99 | + t.Errorf("expected ref=my-app:latest, got %v", receivedBody["ref"]) |
| 100 | + } |
| 101 | + if _, commitIDPresent := receivedBody["commit_id"]; commitIDPresent { |
| 102 | + t.Errorf("expected no 'commit_id' key when IsRef=true, got: %v", receivedBody) |
| 103 | + } |
| 104 | +} |
| 105 | + |
| 106 | +// TestHandleRunCommit_ServerError verifies that non-2xx responses surface as |
| 107 | +// errors to the caller (no silent swallowing). |
| 108 | +func TestHandleRunCommit_ServerError(t *testing.T) { |
| 109 | + server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { |
| 110 | + w.Header().Set("Content-Type", "application/json") |
| 111 | + w.WriteHeader(http.StatusUnprocessableEntity) |
| 112 | + w.Write([]byte(`{"error": "invalid commit id"}`)) |
| 113 | + })) |
| 114 | + defer server.Close() |
| 115 | + |
| 116 | + a := testApp(server.URL) |
| 117 | + _, err := handlers.HandleRunCommit(context.Background(), a, handlers.RunCommitReq{ |
| 118 | + CommitKey: "not-a-uuid", |
| 119 | + IsRef: false, |
| 120 | + }) |
| 121 | + if err == nil { |
| 122 | + t.Fatal("expected error for 422 response, got nil") |
| 123 | + } |
| 124 | +} |
0 commit comments