Commit ff9efbb
committed
fix(update): suppress nag for pseudo-versions and add env-var escape hatch
CI integration test `TestRepoLifecycle` failed on PR #188:
expected 'v1' in quiet tag list, got:
💡 vers update available: v0.0.0-20260506213344-eb1e5d25fa7c -> v0.10.0 (run 'vers upgrade')
Two issues:
1. The integration test runner builds the CLI via `go build` against the
PR merge commit, producing a Go module pseudo-version like
`v0.0.0-<timestamp>-<commit>`. The previous `IsDevVersion` only
matched `dev` / `dev-*` / `*-dirty`, so the pseudo-version sailed
through, hit the live GitHub API, and printed the banner.
2. `testutil.RunVers` uses `cmd.CombinedOutput()`, so even though the
banner correctly writes to stderr, it still ended up in the buffer
that tests parse. Tests doing `strings.TrimSpace(out) != "v1"` are
particularly fragile.
Fixes:
- IsDevVersion now also matches `v0.0.0-...` pseudo-versions. This
protects `go install`, `go run`, and any module-graph build against
an untagged commit — none of which represent a published release the
user can "upgrade" to.
- New `VERS_NO_UPDATE_CHECK` env var (also accepts `NO_UPDATE_NOTIFIER`
for cross-tool consistency with npm) silences the check entirely
before any other logic runs. Truthy parsing follows convention:
unset/empty/0/false/no/off mean "don't suppress", anything else
suppresses.
- testutil.RunVers and RunVersInDir now set `VERS_NO_UPDATE_CHECK=1`
unconditionally so future integration tests are immune to this class
of contamination even if a real release ships during a CI run.
New tests cover pseudo-version detection, both env-var names, and
falsy-value rejection.1 parent 9df98d4 commit ff9efbb
3 files changed
Lines changed: 126 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
32 | 41 | | |
33 | | - | |
34 | | - | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
35 | 57 | | |
36 | 58 | | |
37 | 59 | | |
| |||
227 | 249 | | |
228 | 250 | | |
229 | 251 | | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
230 | 261 | | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
231 | 265 | | |
232 | 266 | | |
233 | 267 | | |
| |||
284 | 318 | | |
285 | 319 | | |
286 | 320 | | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
47 | | - | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
48 | 55 | | |
49 | 56 | | |
50 | 57 | | |
| |||
58 | 65 | | |
59 | 66 | | |
60 | 67 | | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
61 | 128 | | |
62 | 129 | | |
63 | 130 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
85 | 85 | | |
86 | 86 | | |
87 | 87 | | |
88 | | - | |
89 | | - | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
90 | 92 | | |
91 | 93 | | |
92 | 94 | | |
| |||
107 | 109 | | |
108 | 110 | | |
109 | 111 | | |
110 | | - | |
| 112 | + | |
111 | 113 | | |
112 | 114 | | |
113 | 115 | | |
| |||
0 commit comments