Apply suggestions from code review

kgryte · web-flow · commit 5f6d3dabdf07 · 2026-05-11T14:15:10.000-07:00
Co-authored-by: Athan &lt;kgryte@gmail.com&gt;
Signed-off-by: Athan &lt;kgryte@gmail.com&gt;
diff --git a/lib/node_modules/@stdlib/blas/ext/base/clast-index-of-row/lib/clast_index_of_row.js b/lib/node_modules/@stdlib/blas/ext/base/clast-index-of-row/lib/clast_index_of_row.js
@@ -77,7 +77,7 @@ function clastIndexOfRow( order, M, N, A, LDA, x, strideX, workspace, strideW )
 		s = M;
 	}
 	if ( LDA < max( 1, s ) ) {
-		throw new RangeError( format( 'invalid argument. Fifth argument must be a valid stride. Value: `%d`.', LDA ) );
+		throw new RangeError( format( 'invalid argument. Fifth argument must be greater than or equal to max(1,%d). Value: `%d`.', s, LDA ) );
 	}
 	if ( isColumnMajor( order ) ) {
 		sa1 = 1;
diff --git a/lib/node_modules/@stdlib/blas/ext/base/clast-index-of-row/lib/clast_index_of_row.native.js b/lib/node_modules/@stdlib/blas/ext/base/clast-index-of-row/lib/clast_index_of_row.native.js
@@ -70,7 +70,7 @@ function clastIndexOfRow( order, M, N, A, LDA, x, strideX, workspace, strideW )
 		s = M;
 	}
 	if ( LDA < max( 1, s ) ) {
-		throw new RangeError( format( 'invalid argument. Fifth argument must be a valid stride. Value: `%d`.', LDA ) );
+		throw new RangeError( format( 'invalid argument. Fifth argument must be greater than or equal to max(1,%d). Value: `%d`.', s, LDA ) );
 	}
 	return addon( resolveOrder( order ), M, N, reinterpret( A, 0 ), LDA, reinterpret( x, 0 ), strideX, workspace, strideW ); // eslint-disable-line max-len
 }

Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,7 @@ function clastIndexOfRow( order, M, N, A, LDA, x, strideX, workspace, strideW )`
`77`	`77`	`s = M;`
`78`	`78`	`}`
`79`	`79`	`if ( LDA < max( 1, s ) ) {`
`80`		- throw new RangeError( format( 'invalid argument. Fifth argument must be a valid stride. Value: `%d`.', LDA ) );
	`80`	+ throw new RangeError( format( 'invalid argument. Fifth argument must be greater than or equal to max(1,%d). Value: `%d`.', s, LDA ) );
`81`	`81`	`}`
`82`	`82`	`if ( isColumnMajor( order ) ) {`
`83`	`83`	`sa1 = 1;`
Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@ function clastIndexOfRow( order, M, N, A, LDA, x, strideX, workspace, strideW )`
`70`	`70`	`s = M;`
`71`	`71`	`}`
`72`	`72`	`if ( LDA < max( 1, s ) ) {`
`73`		- throw new RangeError( format( 'invalid argument. Fifth argument must be a valid stride. Value: `%d`.', LDA ) );
	`73`	+ throw new RangeError( format( 'invalid argument. Fifth argument must be greater than or equal to max(1,%d). Value: `%d`.', s, LDA ) );
`74`	`74`	`}`
`75`	`75`	`return addon( resolveOrder( order ), M, N, reinterpret( A, 0 ), LDA, reinterpret( x, 0 ), strideX, workspace, strideW ); // eslint-disable-line max-len`
`76`	`76`	`}`