Apply suggestions from code review

kgryte · web-flow · commit 797439eecf93 · 2026-05-10T19:49:21.000-07:00
Co-authored-by: Athan &lt;kgryte@gmail.com&gt;
Signed-off-by: Athan &lt;kgryte@gmail.com&gt;
diff --git a/lib/node_modules/@stdlib/blas/ext/base/sindex-of-column/lib/sindex_of_column.js b/lib/node_modules/@stdlib/blas/ext/base/sindex-of-column/lib/sindex_of_column.js
@@ -76,7 +76,7 @@ function sindexOfColumn( order, M, N, A, LDA, x, strideX, workspace, strideW ) {
 		s = M;
 	}
 	if ( LDA < max( 1, s ) ) {
-		throw new RangeError( format( 'invalid argument. Fifth argument must be a valid stride. Value: `%d`.', LDA ) );
+		throw new RangeError( format( 'invalid argument. Fifth argument must be greater than or equal to max(1,%d). Value: `%d`.', max( 1, s ), LDA ) );
 	}
 	if ( isColumnMajor( order ) ) {
 		sa1 = 1;
diff --git a/lib/node_modules/@stdlib/blas/ext/base/sindex-of-column/lib/sindex_of_column.native.js b/lib/node_modules/@stdlib/blas/ext/base/sindex-of-column/lib/sindex_of_column.native.js
@@ -68,7 +68,7 @@ function sindexOfColumn( order, M, N, A, LDA, x, strideX, workspace, strideW ) {
 		s = M;
 	}
 	if ( LDA < max( 1, s ) ) {
-		throw new RangeError( format( 'invalid argument. Fifth argument must be a valid stride. Value: `%d`.', LDA ) );
+		throw new RangeError( format( 'invalid argument. Fifth argument must be greater than or equal to max(1,%d). Value: `%d`.', max( 1, s ), LDA ) );
 	}
 	return addon( resolveOrder( order ), M, N, A, LDA, x, strideX, workspace, strideW ); // eslint-disable-line max-len
 }

Original file line number	Diff line number	Diff line change
`@@ -76,7 +76,7 @@ function sindexOfColumn( order, M, N, A, LDA, x, strideX, workspace, strideW ) {`
`76`	`76`	`s = M;`
`77`	`77`	`}`
`78`	`78`	`if ( LDA < max( 1, s ) ) {`
`79`		- throw new RangeError( format( 'invalid argument. Fifth argument must be a valid stride. Value: `%d`.', LDA ) );
	`79`	+ throw new RangeError( format( 'invalid argument. Fifth argument must be greater than or equal to max(1,%d). Value: `%d`.', max( 1, s ), LDA ) );
`80`	`80`	`}`
`81`	`81`	`if ( isColumnMajor( order ) ) {`
`82`	`82`	`sa1 = 1;`
Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ function sindexOfColumn( order, M, N, A, LDA, x, strideX, workspace, strideW ) {`
`68`	`68`	`s = M;`
`69`	`69`	`}`
`70`	`70`	`if ( LDA < max( 1, s ) ) {`
`71`		- throw new RangeError( format( 'invalid argument. Fifth argument must be a valid stride. Value: `%d`.', LDA ) );
	`71`	+ throw new RangeError( format( 'invalid argument. Fifth argument must be greater than or equal to max(1,%d). Value: `%d`.', max( 1, s ), LDA ) );
`72`	`72`	`}`
`73`	`73`	`return addon( resolveOrder( order ), M, N, A, LDA, x, strideX, workspace, strideW ); // eslint-disable-line max-len`
`74`	`74`	`}`