fix: apply suggestions from code review

Author: headlessNode

lib/node_modules/@stdlib/blas/ext/base/gcartesian-square/docs/repl.txt

@@ -22,13 +22,13 @@
     N: integer
         Number of indexed elements.
 
-    x: Array<number>|TypedArray
+    x: ArrayLikeObject
         Input array.
 
     strideX: integer
         Stride length for `x`.
 
-    out: Array<number>|TypedArray
+    out: ArrayLikeObject
         Output array.
 
     LDO: integer
@@ -37,7 +37,7 @@
 
     Returns
     -------
-    out: Array<number>|TypedArray
+    out: ArrayLikeObject
         Output array.
 
     Examples
@@ -82,7 +82,7 @@
     N: integer
         Number of indexed elements.
 
-    x: Array<number>|TypedArray
+    x: ArrayLikeObject
         Input array.
 
     sx: integer
@@ -91,7 +91,7 @@
     ox: integer
         Starting index for `x`.
 
-    out: Array<number>|TypedArray
+    out: ArrayLikeObject
         Output array.
 
     so1: integer
@@ -105,7 +105,7 @@
 
     Returns
     -------
-    out: Array<number>|TypedArray
+    out: ArrayLikeObject
         Output array.
 
     Examples

lib/node_modules/@stdlib/blas/ext/base/gcartesian-square/docs/types/index.d.ts

@@ -21,17 +21,17 @@
 /// <reference types="@stdlib/types"/>
 
 import { Layout } from '@stdlib/types/blas';
-import { NumericArray, Collection, AccessorArrayLike } from '@stdlib/types/array';
+import { Collection, AccessorArrayLike } from '@stdlib/types/array';
 
 /**
 * Input array.
 */
-type InputArray = NumericArray | Collection<number> | AccessorArrayLike<number>;
+type InputArray<T> = Collection<T> | AccessorArrayLike<T>;
 
 /**
 * Output array.
 */
-type OutputArray = NumericArray | Collection<number> | AccessorArrayLike<number>;
+type OutputArray<T> = Collection<T> | AccessorArrayLike<T>;
 
 /**
 * Interface describing `gcartesianSquare`.
@@ -55,7 +55,7 @@ interface Routine {
 	* gcartesianSquare( 'row-major', x.length, x, 1, out, 2 );
 	* // out => [ 1.0, 1.0, 1.0, 2.0, 2.0, 1.0, 2.0, 2.0 ]
 	*/
-	<T extends OutputArray>( order: Layout, N: number, x: InputArray, strideX: number, out: T, LDO: number ): T;
+	<T = unknown, U extends OutputArray<T> = OutputArray<T>>( order: Layout, N: number, x: InputArray<T>, strideX: number, out: U, LDO: number ): U;
 
 	/**
 	* Computes the Cartesian square for a strided array using alternative indexing semantics.
@@ -77,7 +77,7 @@ interface Routine {
 	* gcartesianSquare.ndarray( x.length, x, 1, 0, out, 2, 1, 0 );
 	* // out => [ 1.0, 1.0, 1.0, 2.0, 2.0, 1.0, 2.0, 2.0 ]
 	*/
-	ndarray<T extends OutputArray>( N: number, x: InputArray, strideX: number, offsetX: number, out: T, strideOut1: number, strideOut2: number, offsetOut: number ): T;
+	ndarray<T = unknown, U extends OutputArray<T> = OutputArray<T>>( N: number, x: InputArray<T>, strideX: number, offsetX: number, out: U, strideOut1: number, strideOut2: number, offsetOut: number ): U;
 }
 
 /**

lib/node_modules/@stdlib/blas/ext/base/gcartesian-square/docs/types/test.ts

@@ -24,7 +24,7 @@ import gcartesianSquare = require( './index' );
 
 // TESTS //
 
-// The function returns a numeric array...
+// The function returns a collection...
 {
 	const x = new Float64Array( 10 );
 	const out = new Float64Array( 200 );
@@ -63,7 +63,7 @@ import gcartesianSquare = require( './index' );
 	gcartesianSquare( 'row-major', ( x: number ): number => x, x, 1, out, 2 ); // $ExpectError
 }
 
-// The compiler throws an error if the function is provided a third argument which is not a numeric array...
+// The compiler throws an error if the function is provided a third argument which is not a collection...
 {
 	const out = new Float64Array( 200 );
 
@@ -92,7 +92,7 @@ import gcartesianSquare = require( './index' );
 	gcartesianSquare( 'row-major', 10, x, ( x: number ): number => x, out, 2 ); // $ExpectError
 }
 
-// The compiler throws an error if the function is provided a fifth argument which is not a numeric array...
+// The compiler throws an error if the function is provided a fifth argument which is not a collection...
 {
 	const x = new Float64Array( 10 );
 
@@ -135,7 +135,7 @@ import gcartesianSquare = require( './index' );
 	gcartesianSquare( 'row-major', 10, x, 1, out, 2, 10 ); // $ExpectError
 }
 
-// Attached to main export is an `ndarray` method which returns a numeric array...
+// Attached to main export is an `ndarray` method which returns a collection...
 {
 	const x = new Float64Array( 10 );
 	const out = new Float64Array( 200 );
@@ -159,7 +159,7 @@ import gcartesianSquare = require( './index' );
 	gcartesianSquare.ndarray( ( x: number ): number => x, x, 1, 0, out, 2, 1, 0 ); // $ExpectError
 }
 
-// The compiler throws an error if the `ndarray` method is provided a second argument which is not a numeric array...
+// The compiler throws an error if the `ndarray` method is provided a second argument which is not a collection...
 {
 	const out = new Float64Array( 200 );
 
@@ -203,7 +203,7 @@ import gcartesianSquare = require( './index' );
 	gcartesianSquare.ndarray( 10, x, 1, ( x: number ): number => x, out, 2, 1, 0 ); // $ExpectError
 }
 
-// The compiler throws an error if the `ndarray` method is provided a fifth argument which is not a numeric array...
+// The compiler throws an error if the `ndarray` method is provided a fifth argument which is not a collection...
 {
 	const x = new Float64Array( 10 );
 

lib/node_modules/@stdlib/blas/ext/base/gcartesian-square/lib/accessors.js

@@ -26,14 +26,18 @@ var isRowMajor = require( '@stdlib/ndarray/base/assert/is-row-major' );
 // MAIN //
 
 /**
-* Computes the Cartesian square for a strided array using accessor arrays.
+* Computes the Cartesian square for a strided accessor array.
 *
 * @private
 * @param {NonNegativeInteger} N - number of indexed elements
 * @param {Object} x - input array object
+* @param {Collection} x.data - input array data
+* @param {Array<Function>} x.accessors - array element accessors
 * @param {integer} strideX - stride length for `x`
 * @param {NonNegativeInteger} offsetX - starting index for `x`
 * @param {Object} out - output array object
+* @param {Collection} out.data - output array data
+* @param {Array<Function>} out.accessors - array element accessors
 * @param {integer} strideOut1 - stride length for the first dimension of `out`
 * @param {integer} strideOut2 - stride length for the second dimension of `out`
 * @param {NonNegativeInteger} offsetOut - starting index for `out`
@@ -85,7 +89,7 @@ function gcartesianSquare( N, x, strideX, offsetX, out, strideOut1, strideOut2,
 		return obuf;
 	}
 	// Column-major...
-	for ( i = 0; i < N; i++ ) {
+	for ( i = 0; i < N; i++ ) { // Note: these loops inline the equivalent of `gfill` to avoid the overhead of intermediate object creation and accessor dispatch on each call...
 		v = xget( xbuf, ix );
 		for ( j = 0; j < N; j++ ) {
 			oset( obuf, io, v );
@@ -94,7 +98,7 @@ function gcartesianSquare( N, x, strideX, offsetX, out, strideOut1, strideOut2,
 		ix += strideX;
 	}
 	io = offsetOut + strideOut2;
-	for ( i = 0; i < N; i++ ) {
+	for ( i = 0; i < N; i++ ) { // Note: these loops inline the equivalent of `gcopy` to avoid the overhead of intermediate object creation and accessor dispatch on each call...
 		jx = offsetX;
 		for ( j = 0; j < N; j++ ) {
 			oset( obuf, io, xget( xbuf, jx ) );

lib/node_modules/@stdlib/blas/ext/base/gcartesian-square/lib/main.js

@@ -35,13 +35,13 @@ var ndarray = require( './ndarray.js' );
 *
 * @param {string} order - storage layout
 * @param {NonNegativeInteger} N - number of indexed elements
-* @param {NumericArray} x - input array
+* @param {Collection} x - input array
 * @param {integer} strideX - stride length for `x`
-* @param {NumericArray} out - output array
+* @param {Collection} out - output array
 * @param {integer} LDO - stride length between successive contiguous vectors of the matrix `out` (a.k.a., leading dimension of `out`)
 * @throws {TypeError} first argument must be a valid order
 * @throws {RangeError} sixth argument must be a valid stride length
-* @returns {NumericArray} output array
+* @returns {Collection} output array
 *
 * @example
 * var x = [ 1.0, 2.0 ];

lib/node_modules/@stdlib/blas/ext/base/gcartesian-square/lib/ndarray.js

@@ -37,14 +37,14 @@ var accessors = require( './accessors.js' );
 * -   Pairs are stored as rows in the output matrix, where the first column contains the first element of each pair and the second column contains the second element.
 *
 * @param {NonNegativeInteger} N - number of indexed elements
-* @param {NumericArray} x - input array
+* @param {Collection} x - input array
 * @param {integer} strideX - stride length for `x`
 * @param {NonNegativeInteger} offsetX - starting index for `x`
-* @param {NumericArray} out - output array
+* @param {Collection} out - output array
 * @param {integer} strideOut1 - stride length for the first dimension of `out`
 * @param {integer} strideOut2 - stride length for the second dimension of `out`
 * @param {NonNegativeInteger} offsetOut - starting index for `out`
-* @returns {NumericArray} output array
+* @returns {Collection} output array
 *
 * @example
 * var x = [ 1.0, 2.0 ];