refactor: apply suggestions from code review

Author: headlessNode

lib/node_modules/@stdlib/ndarray/to-unflattened/benchmark/benchmark.js

@@ -37,8 +37,8 @@ bench( format( '%s:ctor=base,ndims=1', pkg ), function benchmark( b ) {
 	var buffer;
 	var offset;
 	var dtype;
-	var shape;
 	var order;
+	var shape;
 	var sizes;
 	var out;
 	var i;
@@ -71,11 +71,11 @@ bench( format( '%s:ctor=base,ndims=1', pkg ), function benchmark( b ) {
 
 bench( format( '%s:ctor=ndarray,ndims=1', pkg ), function benchmark( b ) {
 	var strides;
-	var offset;
 	var buffer;
+	var offset;
 	var dtype;
-	var shape;
 	var order;
+	var shape;
 	var sizes;
 	var out;
 	var i;
@@ -108,11 +108,11 @@ bench( format( '%s:ctor=ndarray,ndims=1', pkg ), function benchmark( b ) {
 
 bench( format( '%s:ctor=base,ndims=2', pkg ), function benchmark( b ) {
 	var strides;
-	var offset;
 	var buffer;
+	var offset;
 	var dtype;
-	var shape;
 	var order;
+	var shape;
 	var sizes;
 	var out;
 	var i;
@@ -145,11 +145,11 @@ bench( format( '%s:ctor=base,ndims=2', pkg ), function benchmark( b ) {
 
 bench( format( '%s:ctor=ndarray,ndims=2', pkg ), function benchmark( b ) {
 	var strides;
-	var offset;
 	var buffer;
+	var offset;
 	var dtype;
-	var shape;
 	var order;
+	var shape;
 	var sizes;
 	var out;
 	var i;

lib/node_modules/@stdlib/ndarray/to-unflattened/test/test.js

@@ -22,11 +22,13 @@
 
 var tape = require( 'tape' );
 var isndarrayLike = require( '@stdlib/assert/is-ndarray-like' );
+var isEqualDataType = require( '@stdlib/ndarray/base/assert/is-equal-data-type' );
 var zeroTo = require( '@stdlib/array/zero-to' );
 var ndarray = require( '@stdlib/ndarray/ctor' );
 var array = require( '@stdlib/ndarray/array' );
 var getShape = require( '@stdlib/ndarray/shape' );
 var getDType = require( '@stdlib/ndarray/dtype' );
+var getData = require( '@stdlib/ndarray/data-buffer' );
 var ndarray2array = require( '@stdlib/ndarray/to-array' );
 var toUnflattened = require( './../lib' );
 
@@ -100,7 +102,7 @@ tape( 'the function throws an error if provided a second argument which is not a
 	}
 });
 
-tape( 'the function throws an error if provided a third argument which is not a collection of numbers', function test( t ) {
+tape( 'the function throws an error if provided a third argument which is not an array of nonnegative integers', function test( t ) {
 	var values;
 	var x;
 	var i;
@@ -117,6 +119,7 @@ tape( 'the function throws an error if provided a third argument which is not a
 		void 0,
 		[ '1', '2' ],
 		[ 1.5, 2.5 ],
+		[ -1, 6 ],
 		{},
 		function noop() {}
 	];
@@ -177,7 +180,8 @@ tape( 'the function returns a new ndarray with the unflattened dimension (1D inp
 
 	y = toUnflattened( x, 0, [ 2, 3 ] );
 	t.deepEqual( getShape( y ), [ 2, 3 ], 'returns expected shape' );
-	t.strictEqual( String( getDType( y ) ), String( getDType( x ) ), 'returns expected dtype' );
+	t.strictEqual( isEqualDataType( getDType( y ), getDType( x ) ), true, 'returns expected dtype' );
+	t.notEqual( getData( y ), getData( x ), 'does not share the same data buffer' );
 	t.deepEqual( ndarray2array( y ), expected, 'returns expected value' );
 
 	t.end();
@@ -199,7 +203,8 @@ tape( 'the function returns a new ndarray with the unflattened dimension (1D inp
 
 	y = toUnflattened( x, 0, [ 2, 2, 3 ] );
 	t.deepEqual( getShape( y ), [ 2, 2, 3 ], 'returns expected shape' );
-	t.strictEqual( String( getDType( y ) ), String( getDType( x ) ), 'returns expected dtype' );
+	t.strictEqual( isEqualDataType( getDType( y ), getDType( x ) ), true, 'returns expected dtype' );
+	t.notEqual( getData( y ), getData( x ), 'does not share the same data buffer' );
 	t.deepEqual( ndarray2array( y ), expected, 'returns expected value' );
 
 	t.end();
@@ -221,6 +226,8 @@ tape( 'the function supports negative dimension indices', function test( t ) {
 
 	y = toUnflattened( x, -1, [ 2, 3 ] );
 	t.deepEqual( getShape( y ), [ 2, 3 ], 'returns expected shape' );
+	t.strictEqual( isEqualDataType( getDType( y ), getDType( x ) ), true, 'returns expected dtype' );
+	t.notEqual( getData( y ), getData( x ), 'does not share the same data buffer' );
 	t.deepEqual( ndarray2array( y ), expected, 'returns expected value' );
 
 	t.end();
@@ -237,25 +244,8 @@ tape( 'the function returns a new ndarray that is ndarray-like', function test(
 
 	y = toUnflattened( x, 0, [ 2, 3 ] );
 	t.strictEqual( isndarrayLike( y ), true, 'returns ndarray-like object' );
-
-	t.end();
-});
-
-tape( 'the function returns a new ndarray with the same dtype', function test( t ) {
-	var dtypes;
-	var buf;
-	var x;
-	var y;
-	var i;
-
-	dtypes = [ 'float32', 'float64', 'int32', 'uint8' ];
-
-	for ( i = 0; i < dtypes.length; i++ ) {
-		buf = zeroTo( 6 );
-		x = ndarray( dtypes[ i ], buf, [ 6 ], [ 1 ], 0, 'row-major' );
-		y = toUnflattened( x, 0, [ 2, 3 ] );
-		t.strictEqual( String( getDType( y ) ), dtypes[ i ], 'returns expected dtype for ' + dtypes[ i ] );
-	}
+	t.strictEqual( isEqualDataType( getDType( y ), getDType( x ) ), true, 'returns expected dtype' );
+	t.notEqual( getData( y ), getData( x ), 'does not share the same data buffer' );
 
 	t.end();
 });
@@ -276,6 +266,8 @@ tape( 'the function supports column-major order', function test( t ) {
 
 	y = toUnflattened( x, 0, [ 2, 3 ] );
 	t.deepEqual( getShape( y ), [ 2, 3 ], 'returns expected shape' );
+	t.strictEqual( isEqualDataType( getDType( y ), getDType( x ) ), true, 'returns expected dtype' );
+	t.notEqual( getData( y ), getData( x ), 'does not share the same data buffer' );
 	t.deepEqual( ndarray2array( y ), expected, 'returns expected value' );
 
 	t.end();
@@ -298,6 +290,8 @@ tape( 'the function unflattens a middle dimension in a multidimensional input',
 
 	y = toUnflattened( x, 1, [ 2, 2 ] );
 	t.deepEqual( getShape( y ), [ 3, 2, 2 ], 'returns expected shape' );
+	t.strictEqual( isEqualDataType( getDType( y ), getDType( x ) ), true, 'returns expected dtype' );
+	t.notEqual( getData( y ), getData( x ), 'does not share the same data buffer' );
 	t.deepEqual( ndarray2array( y ), expected, 'returns expected value' );
 
 	t.end();