Enable the test suite on the project.

[dmouse]

Proposal

In order to launch the first stable version, We need to update the test (List below) and create the base for more commands and classes within DrupalConsole.

How can We do

The base class used in all test is BaseTestCase this class provide a lot of Mocks/Stubs that is common like Translator object. For each kind of commands, We need to create a base class like GenerateCommandTest to create Mocks/Stubs for the own kind of class.

My Approach, updating test by test and create the essential code to create the own base for testing Drupal Console
Follow the pattern Test Data Builder but using like Test Double Builder proposed by @MontealegreLuis, We want to write test more legible and easy to maintain.

$command = new ModuleCommand(
            $this->getGenerator(),
            A::validator()->build(),
            '/tmp',
            A::stringConverter()->withInvalidModuleName()->build(),
            A::drupalApi()->withVersion('8.2.0')->build(),
            A::guzzleHttpClient()->build(),
            A::utils->build()
        );

        $commandTester = new CommandTester($command);

        $code = $commandTester->execute(
            [
              '--module'         => $module,
              '--machine-name'   => $machine_name,
              '--module-path'    => $module_path,
              '--description'    => $description,
              '--core'           => $core,
              '--package'        => $package,
              '--features-bundle'=> $featuresBundle,
              '--composer'       => $composer,
              '--dependencies'   => $dependencies
            ],
            ['interactive' => false]
        );

        $this->assertEquals(0, $code);

• BaseTestCase.php
• GenerateCommandTest.php
• GenerateEntityBundleCommandTest.php
• GeneratorAuthenticationProviderCommandTest.php
• GeneratorCommandCommandTest.php
• GeneratorConfigFormBaseCommandTest.php
• GeneratorControllerCommandTest.php
• GeneratorEntityCommandTest.php
• GeneratorEntityConfigCommandTest.php
• GeneratorEntityContentCommandTest.php
• GeneratorFormCommandTest.php
• GeneratorModuleCommandTest.php
• GeneratorPermissionCommandTest.php
• GeneratorPluginBlockCommandTest.php
• GeneratorPluginConditionCommandTest.php
• GeneratorPluginFieldCommandTest.php
• GeneratorPluginFieldFormatterCommandTest.php
• GeneratorPluginFieldTypeCommandTest.php
• GeneratorPluginFieldWidgetCommandTest.php
• GeneratorPluginImageEffectCommandTest.php
• GeneratorPluginImageFormatterCommandTest.php
• GeneratorPluginRestResourceCommandTest.php
• GeneratorPluginRulesActionCommandTest.php
• GeneratorPluginTypeAnnotationCommandTest.php
• GeneratorPluginTypeYamlCommandTest.php
• GeneratorThemeCommandTest.php
• ServiceCommandTest.php
• AuthenticationProviderGeneratorTest.php
• CommandGeneratorTest.php
• ConfigFormBaseGeneratorTest.php
• ContentTypeGeneratorTest.php
• ControllerGeneratorTest.php
• EntityConfigGeneratorTest.php
• EntityContentGeneratorTest.php
• EntityGeneratorTest.php
• FormGeneratorTest.php
• GeneratorTest.php
• ModuleGeneratorTest.php
• PermissionGeneratorTest.php
• PluginBlockGeneratorTest.php
• PluginCKEditorButtonGeneratorTest.php
• PluginConditionGeneratorTest.php
• PluginFieldFormatterGeneratorTest.php
• PluginFieldGeneratorTest.php
• PluginFieldTypeGeneratorTest.php
• PluginFieldWidgetGeneratorTest.php
• PluginImageEffectGeneratorTest.php
• PluginImageFormatterGeneratorTest.php
• PluginRestResourceGeneratorTest.php
• PluginRulesActionGeneratorTest.php
• PluginTypeAnnotationGeneratorTest.php
• PluginTypeYamlGeneratorTest.php
• ProfileGeneratorTest.php
• ServiceGeneratorTest.php
• ThemeGeneratorTest.php

[gapple]

Is there progress or ways to help?

I did the following:

git clone git@github.com:hechoendrupal/drupal-console.git
cd drupal-console
composer install
composer require --dev phpunit/phpunit ^4.8
bin/phpunit

and am met with

PHP Fatal error:  Trait 'Drupal\Console\Helper\HelperTrait' not found in Test/BaseTestCase.php on line 15

The previously referenced commits look like they were merged into the develop branch, but that branch no longer exists and it doesn't look like any of those changes are in the current master branch.

[jmolivas]

@gapple thanks for helping, we started fixing Tests on development and moved to test-suite but been thinking to merging on them on master to continue working on those tests.

Do you think merging into master will make it easy to continue