refactor(feature): 响应 CodeReview 意见，优化 FeatureChain 封装与动态参数适配，补充新手文档

Author: hect0x7

assets/docs/sources/tutorial/13_export_and_feature.md

@@ -44,6 +44,10 @@ download_album('123', option, extra=Feature.export_pdf)
 ├── [JM123]本子标题.pdf       ← 整本合并为 1 个 PDF，注意pdf文件名的格式，默认包含本子禁漫车号+本子标题
 ```
 
+> 💡 **小白提示：当前工作目录在哪？**
+>
+> 默认情况下，文件会直接出现在你**运行 Python 脚本的那个文件夹里**。如果你不知道具体是哪，可以看后面的【自定义参数】章节，手动指定你想保存到的文件夹。
+
 ### 2.2 需要多种导出格式（PDF、ZIP等）——直接组合 Feature
 
 用 `+` 号组合，同时导出多种格式：

src/jmcomic/jm_client_impl.py

@@ -280,9 +280,6 @@ def get_photo_detail(self,
         photo = self.fetch_detail_entity(photo_id, 'photo')
 
         # 一并获取该章节的所处本子
-        # todo: 可优化，获取章节所在本子，其实不需要等待章节获取完毕后。
-        #  可以直接调用 self.get_album_detail(photo_id)，会重定向返回本子的HTML
-        # (had polished by FutureClientProxy)
         if fetch_album is True:
             photo.from_album = self.get_album_detail(photo.album_id)
 
@@ -1205,4 +1202,4 @@ def get_photo_detail(self, photo_id, fetch_album=True, fetch_scramble_id=True) -
         if scramble_id != '':
             photo.scramble_id = scramble_id
 
-        return photo
+        return photo

src/jmcomic/jm_config.py

@@ -591,7 +591,6 @@ def format(self, record):
 def enable_pretty_log():
     """开启带颜色的美化日志"""
     import sys
-    import os as _os
 
     # Windows 需要启用 VT100 ANSI 支持
     if sys.platform == 'win32':

src/jmcomic/jm_downloader.py

@@ -82,7 +82,7 @@ def __init__(self, option: JmOption) -> None:
         self.download_failed_image: List[Tuple[JmImageDetail, BaseException]] = []
         self.download_failed_photo: List[Tuple[JmPhotoDetail, BaseException]] = []
         # Feature 特性列表: [(feature, feature_from), ...]
-        self._feature_list: list = []
+        self._feature_list: List[Tuple] = []
 
     def download_album(self, album_id):
         album = self.client.get_album_detail(album_id)
@@ -292,7 +292,7 @@ def add_features(self, features, feature_from: str):
             for f in features:
                 self.add_features(f, feature_from)
         elif isinstance(features, FeatureChain):
-            for f in features._features:
+            for f in features.to_list():
                 self._feature_list.append((f, feature_from))
         elif isinstance(features, Feature):
             self._feature_list.append((features, feature_from))

src/jmcomic/jm_exception.py

@@ -183,7 +183,7 @@ def new(msg, context=None, _etype=None):
 
     @classmethod
     def notify_all_listeners(cls, e):
-        registry: Dict[Type, Callable[Type]] = JmModuleConfig.REGISTRY_EXCEPTION_LISTENER
+        registry: Dict[Type, Callable] = JmModuleConfig.REGISTRY_EXCEPTION_LISTENER
         if not registry:
             return None
 

src/jmcomic/jm_feature.py

@@ -58,15 +58,15 @@ def invoke(self, option: JmOption, feature_from: str, when: str, **kwargs):
     # ---- 组合运算符，统一返回 FeatureChain ----
 
     def __add__(self, other):
-        return FeatureChain._combine(self, other)
+        return FeatureChain.combine(self, other)
 
     def __or__(self, other):
-        return FeatureChain._combine(self, other)
+        return FeatureChain.combine(self, other)
 
     def __and__(self, other):
-        return FeatureChain._combine(self, other)
+        return FeatureChain.combine(self, other)
 
-    def _to_list(self):
+    def to_list(self):
         return [self]
 
 
@@ -122,7 +122,7 @@ def _adapt_plugin_kwargs(self, feature_from: str, when: str) -> dict:
         filename_rule
         """
         kwargs = self.kwargs.copy()
-        kwargs.setdefault('filename_rule', '[JM{Aid}]{Atitle}' if feature_from == 'download_album' else '[JM{Pid}]{Ptitle}')
+        kwargs.setdefault('filename_rule', '[JM{Aid}]{Atitle}' if when == 'after_album' else '[JM{Pid}]{Ptitle}')
         return kwargs
 
     def __repr__(self):
@@ -139,19 +139,19 @@ def __init__(self, features):
         self._features = features
 
     @classmethod
-    def _combine(cls, left, right):
-        return cls(left._to_list() + right._to_list())
+    def combine(cls, left, right):
+        return cls(left.to_list() + right.to_list())
 
     def __add__(self, other):
-        return FeatureChain._combine(self, other)
+        return FeatureChain.combine(self, other)
 
     def __or__(self, other):
-        return FeatureChain._combine(self, other)
+        return FeatureChain.combine(self, other)
 
     def __and__(self, other):
-        return FeatureChain._combine(self, other)
+        return FeatureChain.combine(self, other)
 
-    def _to_list(self):
+    def to_list(self):
         return list(self._features)
 
     def __repr__(self):

src/jmcomic/jm_toolkit.py

@@ -350,7 +350,7 @@ def to_zh(cls, s, target=None):
         try:
             import zhconv
             return zhconv.convert(s, target)
-        except ImportError as e:
+        except ImportError:
             jm_log('zhconv.error', '繁简转换失败，未安装zhconv，请先使用命令安装: [pip install zhconv]')
             return s
         except Exception as e: