Skip to content

Adds parameter for DateTimeKind#480

Merged
moodmosaic merged 2 commits into
hedgehogqa:masterfrom
njlr:enhancement/issue-426-date-time-kinds
Mar 23, 2026
Merged

Adds parameter for DateTimeKind#480
moodmosaic merged 2 commits into
hedgehogqa:masterfrom
njlr:enhancement/issue-426-date-time-kinds

Conversation

@njlr
Copy link
Copy Markdown
Contributor

@njlr njlr commented Mar 22, 2026

  • Adds the generator Gen.dateTimeKind for DateTimeKind values
  • Adds a parameter to Gen.dateTime for providing a DateTimeKind generator
  • Adds the generator Gen.dateTimeUtc for DateTime values with kind Utc
  • Adds the generator Gen.dateTimeLocal for DateTime values with kind Local
  • Adds the generator Gen.dateTimeUnspecified for DateTime values with kind Unspecified
  • Removes a poorly defined test

This is a (minor) breaking change to Gen.dateTime.

Closes #426

Copy link
Copy Markdown
Member

@moodmosaic moodmosaic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good change! The old Gen.dateTime silently produced DateTimeKind.Unspecified, which could mask bugs where Kind matters.

@moodmosaic
Copy link
Copy Markdown
Member

@njlr, happy to merge this (if you're not planning to add additional commits).

@njlr
Copy link
Copy Markdown
Contributor Author

njlr commented Mar 23, 2026

@njlr, happy to merge this (if you're not planning to add additional commits).

Ready from my end 🙂

@moodmosaic moodmosaic merged commit a5e7761 into hedgehogqa:master Mar 23, 2026
2 checks passed
@moodmosaic
Copy link
Copy Markdown
Member

Thank you, @njlr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extend DateTime generator to use different DateTimeKind values

2 participants