update CI workflow

Author: dealloc

.github/workflows/sync.yml

@@ -1,16 +1,14 @@
 name: Validate sync
 
-# Grant permissions to create issues & PR comments
 permissions:
   contents: read
-  issues: write
   pull-requests: write
 
 on:
   push:
     branches: ["master"]
   pull_request:
-    branches: [ "master" ]
+    branches: ["master"]
   schedule:
     - cron: '0 0 * * *'
 
@@ -19,30 +17,27 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      - name: Checkout code
-        uses: actions/checkout@v3
+      - uses: actions/checkout@v4
 
       - name: Setup .NET
-        uses: actions/setup-dotnet@v3
+        uses: actions/setup-dotnet@v4
         with:
           dotnet-version: '9.0.x'
 
+      - name: Download JSON submodule
+        run: git submodule update --init ./src/Helldivers-2-Models/json
+
       - name: Run sync and capture logs
         id: run_sync
         shell: bash
-        # continue-on-error so we can handle failures in later steps
         continue-on-error: true
         run: |
           set -o pipefail
+          dotnet build
           dotnet run --project ./src/Helldivers-2-CI/Helldivers-2-CI.csproj 2>&1 | tee sync.log
-          EXIT_CODE=${PIPESTATUS[0]}
-          # expose exit code and full log as step outputs
-          echo "exit_code=$EXIT_CODE" >> $GITHUB_OUTPUT
-          echo "log<<EOF" >> $GITHUB_OUTPUT
-          cat sync.log >> $GITHUB_OUTPUT
-          echo "EOF" >> $GITHUB_OUTPUT
 
       - name: Upload artifacts
+        if: always()
         uses: actions/upload-artifact@v4
         with:
           name: sync-artifacts
@@ -51,34 +46,35 @@ jobs:
             v2/*.json
             sync.log
 
-      - name: Create an issue on failure (schedule or push to master)
-        if: steps.run_sync.outputs.exit_code != '0' && github.event_name != 'pull_request'
-        uses: peter-evans/create-pull-request@v7
-        with:
-          title: '[Sync Validation] Failure on ${{ github.ref_name }}'
-          body: |
-            The sync validation run (ID ${{ github.run_id }}) failed with exit code `${{ steps.run_sync.outputs.exit_code }}`.
-
-            **Error log**:
-            ```text
-            ${{ steps.run_sync.outputs.log }}
-            ```
-
-            **Artifacts** (JSON output + log) are available here:
-            ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}/artifacts
+      - name: Capture error log
+        id: sync_log
+        if: ${{ steps.run_sync.outcome == 'failure' && github.event_name == 'pull_request' }}
+        run: |
+          # open a multi-line output called "log"
+          echo "log<<EOF" >> $GITHUB_OUTPUT
+          cat sync.log       >> $GITHUB_OUTPUT
+          echo "EOF"         >> $GITHUB_OUTPUT
 
       - name: Comment on PR on failure
-        if: steps.run_sync.outputs.exit_code != '0' && github.event_name == 'pull_request'
+        if: ${{ steps.run_sync.outcome == 'failure' && github.event_name == 'pull_request' }}
         uses: peter-evans/create-or-update-comment@v4
         with:
+          token: ${{ secrets.GITHUB_TOKEN }}
           issue-number: ${{ github.event.pull_request.number }}
           body: |
-            The sync validation run (ID ${{ github.run_id }}) failed with exit code `${{ steps.run_sync.outputs.exit_code }}`.
+            ⚠️ **Sync validation failed** (run #${{ github.run_number }} exited with ${{ steps.run_sync.outcome }})
+
+            <details>
+              <summary>Error log</summary>
+  
+              ```text
+              ${{ steps.sync_log.outputs.log }}
+              ```
+            </details>
 
-            **Error log**:
-            ```text
-            ${{ steps.run_sync.outputs.log }}
-            ```
+            **Artifacts** (JSON + log) here:  
+            ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}
 
-            **Artifacts** (JSON output + log) are available here:
-            ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}/artifacts
+      - name: Fail job on error
+        if: ${{ steps.run_sync.outcome == 'failure' }}
+        run: exit 1

src/Helldivers-2-SourceGen/Parsers/BaseJsonParser.cs

@@ -40,7 +40,7 @@ public SourceText Parse(AdditionalText file, CancellationToken cancellationToken
             return SourceText.From(output, Encoding.UTF8);
         }
 
-        return SourceText.From("// Could not read JSON file");
+        return SourceText.From("// Could not read JSON file", Encoding.UTF8);
     }
 
     /// <summary>