[HOTFIX] newsfeed (#144)

* improve stacktrace for API errors

* remove offending parameter

* allow manually running sync

* fix formatting

Author: dealloc

.github/workflows/sync.yml

@@ -11,6 +11,7 @@ on:
     branches: ["master"]
   schedule:
     - cron: '0 0 * * *'
+  workflow_dispatch: 
 
 jobs:
   validate-sync:

src/Helldivers-2-Sync/Services/ArrowHeadApiService.cs

@@ -22,6 +22,10 @@ HttpClient http
     {
         var request = BuildRequest("/api/WarSeason/current/WarID");
         using var response = await http.SendAsync(request, cancellationToken);
+
+        // Throw on error responses so we don't have to look down the entire serialisation tree.
+        response.EnsureSuccessStatusCode();
+
         await using var stream = await response.Content.ReadAsStreamAsync(cancellationToken);
         var memory = await CollectStream(stream, cancellationToken);
         var warId = JsonSerializer.Deserialize(
@@ -39,6 +43,10 @@ public async Task<Memory<byte>> GetWarInfo(string season, CancellationToken canc
     {
         var request = BuildRequest($"/api/WarSeason/{season}/WarInfo");
         using var response = await http.SendAsync(request, cancellationToken);
+
+        // Throw on error responses so we don't have to look down the entire serialisation tree.
+        response.EnsureSuccessStatusCode();
+
         await using var stream = await response.Content.ReadAsStreamAsync(cancellationToken);
 
         return await CollectStream(stream, cancellationToken);
@@ -51,6 +59,10 @@ public async Task<Memory<byte>> GetWarStatus(string season, string language, Can
     {
         var request = BuildRequest($"/api/WarSeason/{season}/Status", language);
         using var response = await http.SendAsync(request, cancellationToken);
+
+        // Throw on error responses so we don't have to look down the entire serialisation tree.
+        response.EnsureSuccessStatusCode();
+
         await using var stream = await response.Content.ReadAsStreamAsync(cancellationToken);
 
         return await CollectStream(stream, cancellationToken);
@@ -61,10 +73,13 @@ public async Task<Memory<byte>> GetWarStatus(string season, string language, Can
     /// </summary>
     public async Task<Memory<byte>> LoadFeed(string season, string language, CancellationToken cancellationToken)
     {
-        var request = BuildRequest($"/api/NewsFeed/{season}?maxEntries=1024", language);
+        var request = BuildRequest($"/api/NewsFeed/{season}", language);
         using var response = await http.SendAsync(request, cancellationToken);
-        await using var stream = await response.Content.ReadAsStreamAsync(cancellationToken);
 
+        // Throw on error responses so we don't have to look down the entire serialisation tree.
+        response.EnsureSuccessStatusCode();
+
+        await using var stream = await response.Content.ReadAsStreamAsync(cancellationToken);
         return await CollectStream(stream, cancellationToken);
     }
 
@@ -75,6 +90,10 @@ public async Task<Memory<byte>> LoadAssignments(string season, string language,
     {
         var request = BuildRequest($"/api/v2/Assignment/War/{season}", language);
         using var response = await http.SendAsync(request, cancellationToken);
+
+        // Throw on error responses so we don't have to look down the entire serialisation tree.
+        response.EnsureSuccessStatusCode();
+
         await using var stream = await response.Content.ReadAsStreamAsync(cancellationToken);
 
         return await CollectStream(stream, cancellationToken);
@@ -87,6 +106,10 @@ public async Task<Memory<byte>> LoadSpaceStations(string season, long id, string
     {
         var request = BuildRequest($"/api/SpaceStation/{season}/{id}", language);
         using var response = await http.SendAsync(request, cancellationToken);
+
+        // Throw on error responses so we don't have to look down the entire serialisation tree.
+        response.EnsureSuccessStatusCode();
+
         await using var stream = await response.Content.ReadAsStreamAsync(cancellationToken);
 
         return await CollectStream(stream, cancellationToken);
@@ -99,6 +122,10 @@ public async Task<Memory<byte>> GetSummary(string season, CancellationToken canc
     {
         var request = BuildRequest($"/api/Stats/war/{season}/summary");
         using var response = await http.SendAsync(request, cancellationToken);
+
+        // Throw on error responses so we don't have to look down the entire serialisation tree.
+        response.EnsureSuccessStatusCode();
+
         await using var stream = await response.Content.ReadAsStreamAsync(cancellationToken);
 
         return await CollectStream(stream, cancellationToken);