Skip to content

Fix/sold 62 kolari vision price fix#102

Merged
alexsmithext merged 5 commits into
masterfrom
fix/SOLD-62-kolari-vision-price-fix
May 8, 2026
Merged

Fix/sold 62 kolari vision price fix#102
alexsmithext merged 5 commits into
masterfrom
fix/SOLD-62-kolari-vision-price-fix

Conversation

@alexsmithext
Copy link
Copy Markdown
Contributor

@alexsmithext alexsmithext commented May 8, 2026

Summary by CodeRabbit

Release Notes – Version 1.2.4

  • New Features

    • Added cart offers support in the WooCommerce side cart.
  • Bug Fixes

    • Fixed warranty price hook priority to ensure accurate pricing calculations.
    • Corrected product price data when sending orders to Extend.

@alexsmithext alexsmithext requested a review from jm-extend May 8, 2026 16:48
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 8, 2026

Review Change Stack

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d91297bd-d345-4d95-8677-c375a1a16038

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

This release (1.2.4) contains two key bug fixes for price handling in the HelloExtend WooCommerce plugin. The cart price update logic now runs at a much higher hook priority (99999), skips admin contexts, and correctly sets both product price and regular price while clearing sale price only when extend data is present. Separately, the order payload construction for line items was corrected to avoid double-scaling prices to cents. Plugin version, stable tag, and changelog metadata were updated to document these fixes.

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@helloextend-protection/helloextend-protection.php`:
- Line 19: The plugin header declares Version: 1.2.4 but the runtime constant
HELLOEXTEND_PROTECTION_VERSION is still set to 1.1.0; update the value of the
HELLOEXTEND_PROTECTION_VERSION constant in helloextend-protection.php to match
the header version (1.2.4) so runtime and header stay consistent, and ensure any
usages of HELLOEXTEND_PROTECTION_VERSION elsewhere (e.g., in update checks or
admin notices) will now reflect the correct version.

In `@helloextend-protection/includes/class-helloextend-global.php`:
- Around line 291-293: Replace the empty() check that skips valid zero/"0"
prices by checking presence and numeric-ness instead: locate the conditional
that checks $cart_item['extendData']['price'] (in class HelloExtend_Global,
method handling cart item price) and change the guard from if
(!empty($cart_item['extendData']['price'])) to a check that allows 0 values,
e.g. if (isset($cart_item['extendData']['price']) &&
is_numeric($cart_item['extendData']['price'])) so zero-cent plans are accepted
and then continue to round/convert the price as before.

In `@helloextend-protection/readme.txt`:
- Around line 83-84: The changelog entry text "Decreased priority for warranty
price hook" is misleading because the code sets the hook priority to 99999
(which makes it run later/higher numeric priority); update the wording to
accurately reflect the implementation — e.g. "Increased numeric priority for
warranty price hook so it executes later (priority 99999) / Moved warranty price
hook to run later so plan prices are set correctly" — edit the readme changelog
line that references the warranty price hook to one of these clearer phrasings.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 864dd0f4-09fc-4194-a9d2-0f36c2ddd30e

📥 Commits

Reviewing files that changed from the base of the PR and between ac51085 and a60e34b.

📒 Files selected for processing (4)
  • helloextend-protection/helloextend-protection.php
  • helloextend-protection/includes/class-helloextend-global.php
  • helloextend-protection/includes/class-helloextend-protection-orders.php
  • helloextend-protection/readme.txt

Comment thread helloextend-protection/helloextend-protection.php
Comment thread helloextend-protection/includes/class-helloextend-global.php Outdated
Comment thread helloextend-protection/readme.txt Outdated
jm-extend
jm-extend previously approved these changes May 8, 2026
Copy link
Copy Markdown
Collaborator

@jm-extend jm-extend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i agree with the coderabbit findings. some are less critical than others. i'll leave it up to you.

coderabbitai[bot]
coderabbitai Bot previously approved these changes May 8, 2026
@alexsmithext alexsmithext merged commit 42cfd31 into master May 8, 2026
6 checks passed
@alexsmithext alexsmithext deleted the fix/SOLD-62-kolari-vision-price-fix branch May 8, 2026 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants