fix(scripts): [DEVOPS-2394] pin cx-contrib SHA in build-nodejs.sh

- Drop opentelemetry-js clone + OPENTELEMETRY_JS_PATH. Unused since cx-js
  was dropped (we resolve @opentelemetry/instrumentation from npm now).
- Pin CX_CONTRIB_SHA to match publish-sandbox.sh and the publish workflow
  so local builds don't drift from CI.
- Unify clone path under .build-cache/opentelemetry-js-contrib so both
  scripts share one cache on dev machines.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: jmsundar

scripts/build-nodejs.sh

@@ -1,37 +1,39 @@
 #!/bin/bash
-# This script builds the Node.js Lambda layer for OpenTelemetry instrumentation
+# Builds the Node.js Lambda layer for local dev.
 #
-# The script expects the dependencies to be cloned in specific locations
-# relative to this repository's root directory.
+# Auto-clones the pinned coralogix/opentelemetry-js-contrib fork to .build-cache/
+# on first run. Keep CX_CONTRIB_SHA in sync with:
+#   - scripts/publish-sandbox.sh
+#   - .github/workflows/publish-extend-otel-layer.yml
+#   - UPSTREAM.md fork-points table
 #
-# If you encounter build issues, try cleaning first:
-#   git clean -xdf nodejs
+# Override the clone path with OPENTELEMETRY_JS_CONTRIB_PATH (e.g. to point at
+# a local checkout you are hacking on).
+#
+# If you hit build issues, try: git clean -xdf nodejs
 
 set -euo pipefail
 
 ROOT_DIR=$(git rev-parse --show-toplevel)
 
-# Expected by build_nodejs_layer.sh
-if [ -z "${OPENTELEMETRY_JS_CONTRIB_PATH:-}" ]; then
-	export OPENTELEMETRY_JS_CONTRIB_PATH="$ROOT_DIR/opentelemetry-js-contrib-cx"
-fi
-
-if [ -z "${OPENTELEMETRY_JS_PATH:-}" ]; then
-	export OPENTELEMETRY_JS_PATH="$ROOT_DIR/opentelemetry-js"
-fi
-
+CX_CONTRIB_REPO="https://github.com/coralogix/opentelemetry-js-contrib.git"
+CX_CONTRIB_SHA="3a9691a699ddd06c3644eec70bf4b50cc4217ba3"
+CX_CONTRIB_CACHE="${OPENTELEMETRY_JS_CONTRIB_PATH:-$ROOT_DIR/.build-cache/opentelemetry-js-contrib}"
 
-if [ ! -d "$OPENTELEMETRY_JS_CONTRIB_PATH" ]; then
-	git clone git@github.com:coralogix/opentelemetry-js-contrib.git "$OPENTELEMETRY_JS_CONTRIB_PATH" -b coralogix-autoinstrumentation
+echo "==> resolving cx-contrib fork at $CX_CONTRIB_SHA"
+if [ ! -d "$CX_CONTRIB_CACHE/.git" ]; then
+	mkdir -p "$(dirname "$CX_CONTRIB_CACHE")"
+	git clone --filter=blob:none "$CX_CONTRIB_REPO" "$CX_CONTRIB_CACHE"
 fi
+git -C "$CX_CONTRIB_CACHE" fetch --quiet origin "$CX_CONTRIB_SHA" 2>/dev/null || git -C "$CX_CONTRIB_CACHE" fetch --quiet origin
+git -C "$CX_CONTRIB_CACHE" checkout --quiet "$CX_CONTRIB_SHA"
 
-if [ ! -d "$OPENTELEMETRY_JS_PATH" ]; then
-	git clone git@github.com:coralogix/opentelemetry-js.git "$OPENTELEMETRY_JS_PATH" -b coralogix-autoinstrumentation
-fi
+export OPENTELEMETRY_JS_CONTRIB_PATH
+OPENTELEMETRY_JS_CONTRIB_PATH="$(cd "$CX_CONTRIB_CACHE" && pwd)"
 
 "$ROOT_DIR/scripts/build_nodejs_layer.sh"
 
-# Useful for using the layer locally
+# Unzip layer next to the zip for local Lambda-layer poking
 pushd "$ROOT_DIR/nodejs/packages/layer" >/dev/null
 rm -rf ./build/layer && unzip -q ./build/layer.zip -d ./build/layer
 popd >/dev/null