Skip key normalization in _resolve_indexing_state#2371
Open
brownbaerchen wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the “key normalization” step in heat.core.dndarray._resolve_indexing_state(), aiming to avoid coercing local DNDarray index keys into torch.Tensor (and torch.int64) during indexing resolution.
Changes:
- Removed pre-processing that coerced local (non-distributed)
DNDarrayindex keys (and tuple/list components) totorch.int64tensors before subsequent indexing logic.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| for k in key | ||
| ) | ||
|
|
||
| # 1D boolean mask resolution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests pass (locally) without this, so maybe we can remove this.
Not casting
DNDarraytoTensorwill be helpful in castingTensortoDNDarray...