Skip to content

GaussianNB distributed results deviate from the scikit-learn results #771#2376

Draft
maliesen wants to merge 2 commits into
helmholtz-analytics:mainfrom
maliesen:bugs/771-GaussianNB_distributed_results_deviate_from_the_scikit-learn_results
Draft

GaussianNB distributed results deviate from the scikit-learn results #771#2376
maliesen wants to merge 2 commits into
helmholtz-analytics:mainfrom
maliesen:bugs/771-GaussianNB_distributed_results_deviate_from_the_scikit-learn_results

Conversation

@maliesen

Copy link
Copy Markdown
  • save class_count with split=None so all ranks can access it
  • get the index/mask for the global x with respect to the global y, not y.larray

Due Diligence

  • General:
  • Implementation:
    • unit tests: all split configurations tested
    • unit tests: multiple dtypes tested
    • NEW unit tests: MPS tested (1 MPI process, 1 GPU)
    • benchmarks: created for new functionality
    • benchmarks: performance improved or maintained
    • documentation updated where needed

Description

Issue/s resolved: #

Changes proposed:

Type of change

Memory requirements

Performance

Does this change modify the behaviour of other functions? If so, which?

yes / no

- save class_count with split=None so all ranks can access it
- get the index/mask for the global x with respect to the global y, not y.larray
@brownbaerchen

Copy link
Copy Markdown
Collaborator

Hi, @maliesen! Thanks a lot for getting started on this!

The tests in this PR are failing because some part of our pipeline has recently changed and we have yet to fix that. This has nothing to do with you and I apologize for the inconvenience. We'll try to fix this up as soon as possible.

…to bugs/771-GaussianNB_distributed_results_deviate_from_the_scikit-learn_results
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

2 participants