GaussianNB distributed results deviate from the scikit-learn results #771#2376
Draft
maliesen wants to merge 2 commits into
Conversation
- save class_count with split=None so all ranks can access it - get the index/mask for the global x with respect to the global y, not y.larray
Collaborator
|
Hi, @maliesen! Thanks a lot for getting started on this! The tests in this PR are failing because some part of our pipeline has recently changed and we have yet to fix that. This has nothing to do with you and I apologize for the inconvenience. We'll try to fix this up as soon as possible. |
…to bugs/771-GaussianNB_distributed_results_deviate_from_the_scikit-learn_results
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due Diligence
Description
Issue/s resolved: #
Changes proposed:
Type of change
Memory requirements
Performance
Does this change modify the behaviour of other functions? If so, which?
yes / no