Allow unsafe pr checkout#2391
Open
brownbaerchen wants to merge 5 commits into
Open
Conversation
Member
|
That is a smart idea. I would still keep setup to require approval for first time external people, but not checking their branch to launch the Codebase jobs is a good plan. |
JuanPedroGHM
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the same as #2378, but no longer across forks. Otherwise, the changes don't take effect because we are still running with
pull_request_targetand the tests just fail.I now understand copilot's comments in @2378: For triggering the codebase CI, we don't need the actual code that we want to test. It's suffices to checkout the current main, which contains the action that tells codebase what to check out.
So, by not specifying any
refincheckout, we checkout the base branch, which is safe as it is part of the main repo. This launches the action on codebase and codebase does whatever the PR includes. This may be malicious, but it can't extract secrets from us.We can still choose if we want to always manually trigger workflows from external contributors or only from first time contributors, but I think this solution is good enough either way.