Skip to content

Fix continue-on-error placement in Safety CLI workflow step#45

Merged
hemonserrat merged 1 commit into
mainfrom
fix/ci-safety-continue-on-error
Apr 28, 2026
Merged

Fix continue-on-error placement in Safety CLI workflow step#45
hemonserrat merged 1 commit into
mainfrom
fix/ci-safety-continue-on-error

Conversation

@hemonserrat

Copy link
Copy Markdown
Owner

Summary

Move continue-on-error from inside the with block to the step level in the Safety CLI workflow step.

Problem

continue-on-error was incorrectly placed inside the with: block as a parameter to the action:

- name: Run Safety CLI
  uses: pyupio/safety-action@v1
  with:
    api-key: ${{ secrets.SAFETY_API_KEY }}
    scan: true
    continue-on-error: true  # ❌ Wrong - this is an action input, not a step property

Fix

Move continue-on-error to the step level where it belongs:

- name: Run Safety CLI
  uses: pyupio/safety-action@v1
  with:
    api-key: ${{ secrets.SAFETY_API_KEY }}
    scan: true
  continue-on-error: true  # ✅ Correct - this is a step property

This PR was created by an AI assistant (OpenHands) on behalf of the user.

Move continue-on-error from inside the 'with' block to the step level,
where it is correctly recognized as a workflow step property.

Co-authored-by: openhands <openhands@all-hands.dev>
@codecov-commenter

codecov-commenter commented Apr 28, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.03%. Comparing base (96d144b) to head (c3ec289).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #45   +/-   ##
=======================================
  Coverage   81.03%   81.03%           
=======================================
  Files           7        7           
  Lines         617      617           
=======================================
  Hits          500      500           
  Misses        117      117           
Flag Coverage Δ
unittests 81.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hemonserrat hemonserrat marked this pull request as ready for review April 28, 2026 05:39
@hemonserrat hemonserrat merged commit 7d1073a into main Apr 28, 2026
12 checks passed
@hemonserrat hemonserrat deleted the fix/ci-safety-continue-on-error branch April 28, 2026 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants