Restore a11y functionality on Android (fix for issue 792)#963
Open
rneiss wants to merge 2 commits intohenninghall:masterfrom
Open
Restore a11y functionality on Android (fix for issue 792)#963rneiss wants to merge 2 commits intohenninghall:masterfrom
rneiss wants to merge 2 commits intohenninghall:masterfrom
Conversation
|
Please merge this! |
android/src/main/java/com/henninghall/date_picker/generated/NumberPicker.java
Outdated
Show resolved
Hide resolved
…mberPicker.java Co-authored-by: Oğuzhan Selim Temiz <oguzhanselimtemiz@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Android accessibility issue where the NumberPicker is not exposed to TalkBack and Appium (Issue #792).
Problem
In version 5.0.0, the
setVisibleToUser()calls in the accessibility code were commented out, causing the NumberPicker components to be invisible to accessibility services like TalkBack and automated testing tools like Appium. This made the picker unusable for non-sighted users and prevented native test automation.Solution
Added custom
isPickerVisibleToUser()helper methods that safely check visibility in React Native context by verifying that the View and parents are shown, Positive dimensions exist, and that the View is attached to visiblewindow, and restoredsetVisibleToUser()calls.