chore(ci): unblock lint for PRs#968
Open
idanlevi1 wants to merge 1 commit into
Open
Conversation
Two related fixes so every contributor's PR isn't blocked by an unfixable lint check:
1. `src/DatePickerIOS.js` — apply `yarn lint --fix`. Pre-existing prettier
issues at lines 26-27 that have been failing CI on every PR for months.
2. `.github/workflows/lint.yml` — check out the PR head, not master.
`pr.yml` is triggered by `pull_request_target`, which defaults to the
base branch for the workflow file *and* for the checkout, so lint was
running against master and PR-side fixes were invisible. The other
workflows (build-android, build-ios, test-android-*) already override
this with `ref: ${{ github.event.pull_request.head.sha }}` — mirror
the same pattern here.
Combined, these unblock the lint check on every open PR (the existing
\`yarn lint\` rules are unchanged).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two minimal CI-hygiene fixes that together unblock the lint check on every open PR:
Why
Every PR right now hits the same wall: lint job reports the prettier issue in master's `DatePickerIOS.js`, the PR has no way to fix it (workflow runs against master, not PR), and the PR is blocked. Confirmed by looking at the last ~5 master CI runs — all conclude `failure` on the lint job for unrelated reasons.
This PR breaks the chicken-and-egg by applying the trivial 2-line prettier fix on master directly and patching the workflow so future PRs can actually be linted.
Test plan