Skip to content

chore(ci): unblock lint for PRs #968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
idanlevi1 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore(ci): unblock lint for PRs #968

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,14 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v4
with:
# Required because pr.yml uses `pull_request_target`, which
# otherwise checks out the base branch (master) instead of the
# PR head. Without this override, lint runs against master and
# PR-side fixes (or breaks) are invisible to the check.
# Mirrors the pattern already used in build-android.yml /
# build-ios.yml / test-android-*.yml.
ref: ${{ github.event.pull_request.head.sha }}

- name: Node
uses: actions/setup-node@v4
Expand Down
8 changes: 6 additions & 2 deletions src/DatePickerIOS.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,12 @@
style: [styles.datePickerIOS, props.style],
date: props.date ? props.date.toISOString() : undefined,
locale: props.locale ? props.locale : undefined,
maximumDate: props.maximumDate ? props.maximumDate.toISOString() : undefined,
minimumDate: props.minimumDate ? props.minimumDate.toISOString() : undefined,
maximumDate: props.maximumDate

Check failure on line 26 in src/DatePickerIOS.js

View workflow job for this annotation

GitHub Actions / Check / Lint 

Replace `·?·props.maximumDate.toISOString()` with `⏎······?·props.maximumDate.toISOString()⏎·····`
? props.maximumDate.toISOString()

Check failure on line 27 in src/DatePickerIOS.js

View workflow job for this annotation

GitHub Actions / Check / Lint 

Replace `·?·props.minimumDate.toISOString()` with `⏎······?·props.minimumDate.toISOString()⏎·····`
: undefined,
minimumDate: props.minimumDate
? props.minimumDate.toISOString()
: undefined,
theme: props.theme ? props.theme : 'auto',
}

Expand Down
Loading