fix(ios): prevent modal confirm button overlap with font scaling#969
Open
dishantwalia wants to merge 2 commits into
Open
fix(ios): prevent modal confirm button overlap with font scaling#969dishantwalia wants to merge 2 commits into
dishantwalia wants to merge 2 commits into
Conversation
Fixes confirm/cancel buttons becoming untappable when Dynamic Type is enabled in portrait and landscape modal date pickers. - Expand height adjustments to standard Dynamic Type categories - Add landscape height buffer and picker clipping - Reserve button touch area above UIAlertAction rows Refs henninghall#960 Refs punchhdev.atlassian.net/browse/MF-3464 Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
dishantwalia
requested a deployment
to
e2e Android
GitHub Actions
Waiting
Rework layout math so alert height is derived from title + picker + scaled action-button area, then capped to available screen height. Prevents picker/action overlap in landscape with Dynamic Type. Refs henninghall#960 Refs punchhdev.atlassian.net/browse/MF-3464 Co-authored-by: Cursor <cursoragent@cursor.com>
dishantwalia
requested a deployment
to
e2e Android
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the iOS modal date picker layout when Dynamic Type / font scaling is enabled. The embedded
UIDatePickersubview could overlap theUIAlertActionbutton touch area, making Confirm/Cancel untappable — reported in portrait and landscape.Changes
LargethroughExtraExtraExtraLarge), not only accessibility tiersstatusBarOrientationfor reliable landscape detectionRelated issues
Test plan