Remove deprecated CreateDefaultNetwork function (#1557)

It was unused already

Relates-To: OCMAM-212

Signed-off-by: Andrey Kashcheev <ext-andrey.kashcheev@here.com>

Author: andrey-kashcheev

olp-cpp-sdk-core/include/olp/core/http/Network.h

@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2019-2023 HERE Europe B.V.
+ * Copyright (C) 2019-2024 HERE Europe B.V.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -147,13 +147,6 @@ class CORE_API Network {
   virtual Statistics GetStatistics(uint8_t bucket_id = 0);
 };
 
-/// Creates a default `Network` implementation.
-OLP_SDK_DEPRECATED(
-    "Will be removed by 05.2024, use "
-    "CreateDefaultNetwork(NetworkInitializationSettings) instead")
-CORE_API std::shared_ptr<Network> CreateDefaultNetwork(
-    size_t max_requests_count);
-
 /// Creates a default `Network` implementation.
 CORE_API std::shared_ptr<Network> CreateDefaultNetwork(
     NetworkInitializationSettings settings);

olp-cpp-sdk-core/src/http/Network.cpp

@@ -65,12 +65,6 @@ Network::Statistics Network::GetStatistics(uint8_t /*bucket_id*/) {
   return Network::Statistics{};
 }
 
-std::shared_ptr<Network> CreateDefaultNetwork(size_t max_requests_count) {
-  NetworkInitializationSettings settings;
-  settings.max_requests_count = max_requests_count;
-  return CreateDefaultNetwork(std::move(settings));
-}
-
 std::shared_ptr<Network> CreateDefaultNetwork(
     NetworkInitializationSettings settings) {
   auto network = CreateDefaultNetworkImpl(std::move(settings));