Exclude RapidJSON from build

Migrating to boost::json

Relates-To: OCMAM-447
Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com>

Author: rustam-gamidov-here

README.md

@@ -64,7 +64,6 @@ The table below lists the dependencies of the Data SDK.
 | Boost (headers only) | 1.82.0              |
 | LevelDB              | 1.21                |
 | Snappy               | 1.1.7               |
-| RapidJSON            | latest              |
 | Zlib                 | 1.3.1               |
 
 ### Linux dependencies

docs/get-started.md

@@ -71,7 +71,7 @@ cmake --build . --target install
 
 <a href="https://cmake.org/download/" target="_blank">CMake</a> is the main build system. The minimal required version of CMake is 3.9.
 
-CMake downloads <a href="https://github.com/google/leveldb" target="_blank">LevelDB</a>, <a href="https://github.com/google/snappy" target="_blank">Snappy</a>, <a href="https://github.com/Tencent/rapidjson" target="_blank">RapidJSON</a>, and <a href="https://www.boost.org/" target="_blank">Boost</a>. To disable downloading, set `OLP_SDK_BUILD_EXTERNAL_DEPS` to `OFF`. For details on CMake flags, see the [related](#cmake-flags) section.
+CMake downloads <a href="https://github.com/google/leveldb" target="_blank">LevelDB</a>, <a href="https://github.com/google/snappy" target="_blank">Snappy</a>, and <a href="https://www.boost.org/" target="_blank">Boost</a>. To disable downloading, set `OLP_SDK_BUILD_EXTERNAL_DEPS` to `OFF`. For details on CMake flags, see the [related](#cmake-flags) section.
 
 **To build the Data SDK:**
 

docs/work-with-data-apis.md

@@ -59,7 +59,7 @@ The example below demonstrates how to use the `olp::client::OlpClient` class fro
     }
     ```
 
-5. If the check passed and the status of the received `olp::client::HttpResponse` is `olp::http::HttpStatusCode::OK` (that is 200 OK), extract the encoded JSON from the response and parse it using RapidJSON or any other JSON parsing library.
+5. If the check passed and the status of the received `olp::client::HttpResponse` is `olp::http::HttpStatusCode::OK` (that is 200 OK), extract the encoded JSON from the response and parse it using JSON parsing library.
 
     ```cpp
     std::string response_json;

external/CMakeLists.txt

@@ -48,10 +48,6 @@ set(OLP_SDK_CPP_SNAPPY_TAG "1.1.7")
 set(OLP_SDK_CPP_LEVELDB_URL "https://github.com/google/leveldb.git")
 set(OLP_SDK_CPP_LEVELDB_TAG "1.21")
 
-set(OLP_SDK_CPP_RAPIDJSON_URL "https://github.com/Tencent/rapidjson.git")
-# Next commit after that breaks our build
-set(OLP_SDK_CPP_RAPIDJSON_TAG "d621dc9e9c77f81e5c8a35b8dcc16dcd63351321")
-
 set(OLP_SDK_CPP_BOOST_URL "https://github.com/boostorg/boost.git")
 set(OLP_SDK_CPP_BOOST_TAG "boost-1.82.0")
 
@@ -73,11 +69,6 @@ if(NOT TARGET GTest AND NOT GTest_FOUND)
     add_subdirectory(googletest)
 endif()
 
-find_package(RapidJSON 1.1.0 QUIET)
-if(NOT TARGET RapidJSON AND NOT RapidJSON_FOUND)
-    add_subdirectory(rapidjson)
-endif()
-
 if(OLP_SDK_ENABLE_DEFAULT_CACHE)
     find_package(leveldb QUIET)
     if(NOT TARGET leveldb AND NOT leveldb_FOUND)

external/rapidjson/CMakeLists.txt

@@ -63,9 +63,6 @@ void from_json(const boost::json::value& value, model::Schema& x) {
 }
 
 void from_json(const boost::json::value& value, model::StreamProperties& x) {
-  // Parsing these as double even though OepnAPI sepcs says int64 because
-  // Backend returns the value in decimal format (e.g. 1.0) and this triggers an
-  // assert in RapidJSON when parsing.
   x.SetDataInThroughputMbps(
       static_cast<int64_t>(parse<double>(value, "dataInThroughputMbps")));
   x.SetDataOutThroughputMbps(

external/rapidjson/CMakeLists.txt.rapidjson.in

@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2024 HERE Europe B.V.
+ * Copyright (C) 2024-2026 HERE Europe B.V.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -55,7 +55,6 @@ class ByteVectorBuffer {
   Buffer GetBuffer() { return buffer_; }
 
  private:
-  // Using the same value as rapidjson
   static constexpr auto kDefaultCapacity = 256u;
   Buffer buffer_;
 };

olp-cpp-sdk-dataservice-read/src/generated/parser/CatalogParser.cpp

@@ -63,9 +63,6 @@ void from_json(const boost::json::value& value, model::Schema& x) {
 }
 
 void from_json(const boost::json::value& value, model::StreamProperties& x) {
-  // Parsing these as double even though OepnAPI sepcs says int64 because
-  // Backend returns the value in decimal format (e.g. 1.0) and this triggers an
-  // assert in RapidJSON when parsing.
   x.SetDataInThroughputMbps(
       static_cast<int64_t>(parse<double>(value, "dataInThroughputMbps")));
   x.SetDataOutThroughputMbps(

olp-cpp-sdk-dataservice-read/src/generated/serializer/ByteVectorBuffer.h

@@ -333,8 +333,8 @@ TEST(ParserTest, Catalog) {
 
 // TODO Test specfically for handling of OLP Backend bug:
 // Parse dataOutThroughputMbps, dataInThroughputMbps as double even though
-// OepnAPI sepcs says int64 because OLP Backend returns the value in decimal
-// format (e.g. 1.0) and this triggers an assert in RapidJSON when parsing.
+// OpenAPI sepcs says int64 because OLP Backend returns the value in decimal
+// format (e.g. 1.0).
 TEST(ParserTest, CatalogCrash) {
   std::string json_input =
       "{\"id\":\"olp-cpp-sdk-ingestion-test-catalog\",\"hrn\":\"hrn:here:data::"