Custom implementation of RFC1123 Parser

Signed-off-by: Mykhailo Diachenko <ext-mykhailo.z.diachenko@here.com>

Author: diachenko-mischa

olp-cpp-sdk-authentication/src/AuthenticationClientUtils.cpp

@@ -30,10 +30,8 @@
 #include <rapidjson/istreamwrapper.h>
 #include <rapidjson/stringbuffer.h>
 #include <rapidjson/writer.h>
-#include <boost/date_time/gregorian/gregorian.hpp>
-#include <boost/date_time/posix_time/posix_time.hpp>
-#include <boost/date_time/time_facet.hpp>
 #include "Constants.h"
+#include "Rfc1123Helper.h"
 #include "ResponseFromJsonBuilder.h"
 #include "olp/core/http/NetworkResponse.h"
 #include "olp/core/http/NetworkUtils.h"
@@ -61,19 +59,6 @@ constexpr auto kOauthTimestamp = "oauth_timestamp";
 constexpr auto kOauthSignatureMethod = "oauth_signature_method";
 constexpr auto kVersion = "1.0";
 constexpr auto kHmac = "HMAC-SHA256";
-constexpr auto kLogTag = "AuthenticationClientUtils";
-// %e: day with optional leading space/zero.
-// %H remains strict two-digit hour in input facet.
-constexpr auto kRfc1123GmtFormat = "%a, %e %b %Y %H:%M:%S GMT";
-
-std::string TrimDateHeaderValue(const std::string& value) {
-  const auto begin = value.find_first_not_of(" \t\r\n");
-  if (begin == std::string::npos) {
-    return {};
-  }
-  const auto end = value.find_last_not_of(" \t\r\n");
-  return value.substr(begin, end - begin + 1);
-}
 
 std::string Base64Encode(const Crypto::Sha256Digest& digest) {
   std::string ret = olp::utils::Base64Encode(digest.data(), digest.size());
@@ -113,89 +98,10 @@ namespace client = olp::client;
 
 constexpr auto kDate = "date";
 
-#ifdef _WIN32
-// Windows does not have ::strptime and ::timegm
 std::time_t ParseTime(const std::string& value) {
-  std::tm tm = {};
-  std::istringstream ss(value);
-  ss >> std::get_time(&tm, "%a, %d %b %Y %H:%M:%S %z");
-  return _mkgmtime(&tm);
+  return internal::ParseRfc1123GmtNoExceptions(value);
 }
 
-#else
-
-std::time_t ParseTime(const std::string& value) {
-  const auto trimmed_value = TrimDateHeaderValue(value);
-  if (trimmed_value.empty()) {
-    OLP_SDK_LOG_WARNING_F(kLogTag,
-                          "Failed to parse Date header '%s': value is empty "
-                          "after trimming whitespace",
-                          value.c_str());
-    return static_cast<std::time_t>(-1);
-  }
-
-  std::istringstream stream(trimmed_value);
-
-  // Facet has internal counter, which is incremented by the std::locale.
-  // When last locale pointing to the facet is destroyed, the counter is
-  // decremented and the facet is destroyed.
-  stream.imbue(
-      std::locale(std::locale::classic(),
-                  new boost::posix_time::time_input_facet(kRfc1123GmtFormat)));
-
-  boost::posix_time::ptime parsed_time;
-  stream >> parsed_time;
-  if (stream.fail()) {
-    OLP_SDK_LOG_WARNING_F(kLogTag,
-                          "Failed to parse Date header '%s': format mismatch "
-                          "for RFC1123 timestamp",
-                          value.c_str());
-    return static_cast<std::time_t>(-1);
-  }
-
-  if (parsed_time.is_not_a_date_time()) {
-    OLP_SDK_LOG_WARNING_F(kLogTag,
-                          "Failed to parse Date header '%s': parsed value is "
-                          "not a valid date/time",
-                          value.c_str());
-    return static_cast<std::time_t>(-1);
-  }
-
-  stream >> std::ws;
-  if (!stream.eof()) {
-    OLP_SDK_LOG_WARNING_F(kLogTag,
-                          "Failed to parse Date header '%s': unexpected "
-                          "trailing characters after timestamp",
-                          value.c_str());
-    return static_cast<std::time_t>(-1);
-  }
-
-  const auto epoch =
-      boost::posix_time::ptime(boost::gregorian::date(1970, 1, 1));
-  if (parsed_time < epoch) {
-    OLP_SDK_LOG_WARNING_F(
-        kLogTag,
-        "Failed to parse Date header '%s': timestamp is before Unix epoch",
-        value.c_str());
-    return static_cast<std::time_t>(-1);
-  }
-
-  const auto seconds_since_epoch = (parsed_time - epoch).total_seconds();
-  using SecondsType = boost::remove_cv_t<decltype(seconds_since_epoch)>;
-  if (seconds_since_epoch >
-      static_cast<SecondsType>(std::numeric_limits<std::time_t>::max())) {
-    OLP_SDK_LOG_WARNING_F(
-        kLogTag,
-        "Failed to parse Date header '%s': timestamp exceeds std::time_t range",
-        value.c_str());
-    return static_cast<std::time_t>(-1);
-  }
-
-  return static_cast<std::time_t>(seconds_since_epoch);
-}
-
-#endif
-
 porting::optional<std::time_t> GetTimestampFromHeaders(
     const olp::http::Headers& headers) {
   auto it =