Skip to content

Commit 9a28842

Browse files
committed
Use std::optional if available.
Currently, SDK requires C++11 minimum. So, boost::optional type is used for optional values. For C++17 and above more convenient is to use std::optional instead. This PR makes the optional type used configurable. Fix clang builds. Relates-To: NLAM-23 Signed-off-by: sopov <ext-alexander.sopov@here.com>
1 parent 10b63ea commit 9a28842

2 files changed

Lines changed: 3 additions & 4 deletions

File tree

examples/ReadExample.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -204,8 +204,8 @@ int RunExampleRead(const AccessKey& access_key, const std::string& catalog,
204204
if (!first_partition_id.empty()) {
205205
// Retrieve the partition data
206206
// Create a DataRequest with appropriate LayerId and PartitionId
207-
auto request = olp::dataservice::read::DataRequest()
208-
.WithPartitionId(first_partition_id);
207+
auto request = olp::dataservice::read::DataRequest().WithPartitionId(
208+
first_partition_id);
209209

210210
// Run the DataRequest
211211
auto future = layer_client.GetData(request);

examples/StreamLayerReadExample.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,7 @@ int GetDataFromMessages(dataread::StreamLayerClient& client,
6363
auto handle = message.GetMetaData().GetDataHandle();
6464
if (handle) {
6565
OLP_SDK_LOG_INFO_F(kLogTag, "Message data: handle - %s, size - %lu",
66-
handle->c_str(),
67-
*message.GetMetaData().GetDataSize());
66+
handle->c_str(), *message.GetMetaData().GetDataSize());
6867
// use GetData(const model::Message& message) with message instance to
6968
// request actual data with data handle.
7069
auto message_future = client.GetData(message);

0 commit comments

Comments
 (0)