Skip to content

Commit b7e2bcb

Browse files
authored
Fix compilation of AlignedBox (#1549)
Not all template functions were actually compiling, and no test ever instantiated the classes fully. Relates-To: MINOR Signed-off-by: Christian Vetter <christian.vetter@here.com>
1 parent 17f6a68 commit b7e2bcb

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

olp-cpp-sdk-core/include/olp/core/math/AlignedBox.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -424,8 +424,8 @@ bool AlignedBox<T, N>::Intersects(const AlignedBox& box) const {
424424
return false;
425425
}
426426

427-
const VectorType& otherMin = box.min();
428-
const VectorType& otherMax = box.max();
427+
const VectorType& otherMin = box.Minimum();
428+
const VectorType& otherMax = box.Maximum();
429429
for (unsigned dim = 0; dim < dimensions; dim++) {
430430
if ((maximum_[dim] < otherMin[dim]) || (minimum_[dim] > otherMax[dim]))
431431
return false;
@@ -462,12 +462,12 @@ bool AlignedBox<T, N>::operator==(const AlignedBox& box) const {
462462
// empty.
463463
//
464464
bool thisEmpty = Empty();
465-
bool otherEmpty = box.empty();
465+
bool otherEmpty = box.Empty();
466466
if (thisEmpty || otherEmpty) {
467467
return thisEmpty == otherEmpty;
468468
}
469469

470-
return minimum_ == box.min() && maximum_ == box.max();
470+
return minimum_ == box.Minimum() && maximum_ == box.Maximum();
471471
}
472472

473473
template <typename T, unsigned int N>

0 commit comments

Comments
 (0)