OLPHttpTask to lock toIgnoreResponse before usage (#1560)

rustam-gamidov-here · web-flow · commit e1ef3e73027b · 2024-10-24T11:35:45.000+03:00
It is 'synchronized' in the didCompleteWithError callback so it's better
to add 'synchronized' in the restarting as well

Relates-To: DATASDK-45

Signed-off-by: Rustam Gamidov &lt;ext-rustam.gamidov@here.com&gt;
diff --git a/olp-cpp-sdk-core/src/http/ios/OLPHttpTask.mm b/olp-cpp-sdk-core/src/http/ios/OLPHttpTask.mm
@@ -98,7 +98,9 @@ - (OLPHttpTaskStatus)restart {
   }
 
   if (_dataTask) {
-    _httpClient.toIgnoreResponse[_dataTask.taskDescription] = _dataTask;
+    @synchronized(_httpClient.toIgnoreResponse) {
+      _httpClient.toIgnoreResponse[_dataTask.taskDescription] = _dataTask;
+    }
     [_dataTask cancel];
     _dataTask = nil;
   }

Original file line number	Diff line number	Diff line change
`@@ -98,7 +98,9 @@ - (OLPHttpTaskStatus)restart {`
`98`	`98`	`}`
`99`	`99`
`100`	`100`	`if (_dataTask) {`
`101`		`- _httpClient.toIgnoreResponse[_dataTask.taskDescription] = _dataTask;`
	`101`	`+ @synchronized(_httpClient.toIgnoreResponse) {`
	`102`	`+ _httpClient.toIgnoreResponse[_dataTask.taskDescription] = _dataTask;`
	`103`	`+ }`
`102`	`104`	`[_dataTask cancel];`
`103`	`105`	`_dataTask = nil;`
`104`	`106`	`}`