Skip to content

Commit e2e5a13

Browse files
committed
Use std::optional if available.
Currently, SDK requires C++11 minimum. So, boost::optional type is used for optional values. For C++17 and above more convenient is to use std::optional instead. This PR makes the optional type used configurable. Fix coverage build. Relates-To: NLAM-23 Signed-off-by: sopov <ext-alexander.sopov@here.com>
1 parent 382e9cf commit e2e5a13

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

  • olp-cpp-sdk-dataservice-read/include/olp/dataservice/read

olp-cpp-sdk-dataservice-read/include/olp/dataservice/read/DataRequest.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ class DATASERVICE_READ_API DataRequest final {
167167
template <class T>
168168
typename std::enable_if<
169169
std::is_same<T, boost::optional<std::string>>::value &&
170-
std::is_same<T, porting::optional<std::string>>::value,
170+
std::is_constructible<porting::optional<std::string>, T>::value,
171171
DataRequest&>::type
172172
WithBillingTag(porting::optional<std::string> tag) {
173173
billing_tag_ = std::move(tag);

0 commit comments

Comments
 (0)