pip/pylock-full-hashes#99
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the integration test by replacing the generic README.md with documentation for a full hashes test using pylock. It introduces a new pylock.toml file specifying several Python packages with their respective source distributions, wheels, archive URLs, and SHA-256 hashes, and adds a setup.cfg file with package metadata. The reviewer suggested updating the package name in setup.cfg from pip-pylock-with-deps to pip-pylock-full-hashes to ensure consistency with the test case name.
| @@ -0,0 +1,3 @@ | |||
| [metadata] | |||
| name = pip-pylock-with-deps | |||
There was a problem hiding this comment.
The package name in setup.cfg is set to pip-pylock-with-deps, but this test case is for pip/pylock-full-hashes. It seems like this was copied from another test case and not updated. Please update the name to pip-pylock-full-hashes to maintain consistency with the test case name.
name = pip-pylock-full-hashes
Signed-off-by: Jakub Nekvinda <jnekvind@redhat.com>
1b3df6c to
750e439
Compare
No description provided.