Skip to content

pip/pylock-full-hashes#99

Closed
ST3V1K wants to merge 1 commit into
hermetoproject:pip/pylock-full-hashesfrom
ST3V1K:pip/pylock-full-hashes
Closed

pip/pylock-full-hashes#99
ST3V1K wants to merge 1 commit into
hermetoproject:pip/pylock-full-hashesfrom
ST3V1K:pip/pylock-full-hashes

Conversation

@ST3V1K

@ST3V1K ST3V1K commented Jun 1, 2026

Copy link
Copy Markdown

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the integration test by replacing the generic README.md with documentation for a full hashes test using pylock. It introduces a new pylock.toml file specifying several Python packages with their respective source distributions, wheels, archive URLs, and SHA-256 hashes, and adds a setup.cfg file with package metadata. The reviewer suggested updating the package name in setup.cfg from pip-pylock-with-deps to pip-pylock-full-hashes to ensure consistency with the test case name.

Comment thread setup.cfg
@@ -0,0 +1,3 @@
[metadata]
name = pip-pylock-with-deps

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The package name in setup.cfg is set to pip-pylock-with-deps, but this test case is for pip/pylock-full-hashes. It seems like this was copied from another test case and not updated. Please update the name to pip-pylock-full-hashes to maintain consistency with the test case name.

name = pip-pylock-full-hashes

Signed-off-by: Jakub Nekvinda <jnekvind@redhat.com>
@ST3V1K ST3V1K force-pushed the pip/pylock-full-hashes branch from 1b3df6c to 750e439 Compare June 1, 2026 07:52
@ST3V1K ST3V1K deleted the branch hermetoproject:pip/pylock-full-hashes July 8, 2026 10:33
@ST3V1K ST3V1K closed this Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant