Skip to content

Commit 07d3301

Browse files
authored
Merge pull request #2415 from hermit-os/dynamic-log-env
feat(env): make `NO_COLOR` and `HERMIT_LOG_LEVEL_FILTER` respect the runtime environment
2 parents 2934193 + 84dde3b commit 07d3301

5 files changed

Lines changed: 3 additions & 5 deletions

File tree

src/arch/aarch64/kernel/mod.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,6 @@ pub fn boot_processor_init() {
8181
crate::mm::init();
8282
crate::mm::print_information();
8383
CoreLocal::get().add_irq_counter();
84-
env::init();
8584
interrupts::init();
8685
processor::detect_frequency();
8786
crate::logging::KERNEL_LOGGER.set_time(true);

src/arch/riscv64/kernel/mod.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,6 @@ pub fn boot_processor_init() {
9999
devicetree::init();
100100
crate::mm::init();
101101
crate::mm::print_information();
102-
env::init();
103102
interrupts::install();
104103

105104
finish_processor_init();

src/arch/x86_64/kernel/mod.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,6 @@ pub fn boot_processor_init() {
9595
crate::mm::init();
9696
crate::mm::print_information();
9797
CoreLocal::get().add_irq_counter();
98-
env::init();
9998
gdt::add_current_core();
10099
interrupts::load_idt();
101100
pic::init();

src/lib.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -234,6 +234,7 @@ fn boot_processor_main() -> ! {
234234
// Initialize the kernel and hardware.
235235
mm::claim_initial_heap();
236236
hermit_sync::Lazy::force(&console::CONSOLE);
237+
env::init();
237238
unsafe {
238239
logging::init();
239240
}

src/logging.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,13 +101,13 @@ impl fmt::Display for ColorLevel {
101101
}
102102

103103
fn no_color() -> bool {
104-
option_env!("NO_COLOR").is_some_and(|val| !val.is_empty())
104+
hermit_var!("NO_COLOR").is_some_and(|val| !val.is_empty())
105105
}
106106

107107
pub unsafe fn init() {
108108
log::set_logger(&KERNEL_LOGGER).expect("Can't initialize logger");
109109
// Determines LevelFilter at compile time
110-
let log_level: Option<&'static str> = option_env!("HERMIT_LOG_LEVEL_FILTER");
110+
let log_level = hermit_var!("HERMIT_LOG_LEVEL_FILTER");
111111
let mut max_level = LevelFilter::Info;
112112

113113
if let Some(log_level) = log_level {

0 commit comments

Comments
 (0)