Skip to content

Commit 1391ad4

Browse files
committed
fix(vsock): Fix formating issue and code style
1 parent 7ac2c31 commit 1391ad4

3 files changed

Lines changed: 32 additions & 38 deletions

File tree

src/executor/vsock.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,8 +87,7 @@ async fn vsock_run() {
8787
let header_cid_inner: u32 = header_cid;
8888
let raw_port = header.src_port.to_ne();
8989
let raw = if matches!(op, Op::Rw | Op::Shutdown | Op::CreditUpdate | Op::Response) {
90-
if let Some(conn) =
91-
vsock_guard.get_mut_connected(port, header_cid_inner, raw_port)
90+
if let Some(conn) = vsock_guard.get_mut_connected(port, header_cid_inner, raw_port)
9291
{
9392
conn
9493
} else if let Some(s) = vsock_guard.get_mut_socket(port) {

src/fd/socket/vsock.rs

Lines changed: 28 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -256,42 +256,37 @@ impl ObjectInterface for Socket {
256256
}
257257
}
258258
VsockState::ReceiveRequest => {
259-
let result = {
260-
const HEADER_SIZE: usize = size_of::<Hdr>();
261-
let mut driver_guard = hardware::get_vsock_driver().unwrap().lock();
262-
let local_cid = driver_guard.get_cid();
263-
264-
driver_guard.send_packet(HEADER_SIZE, |buffer| {
265-
let response = unsafe { &mut *buffer.as_mut_ptr().cast::<Hdr>() };
266-
267-
response.src_cid = le64::from_ne(local_cid);
268-
response.dst_cid = le64::from_ne(raw.remote_cid.into());
269-
response.src_port = le32::from_ne(port);
270-
response.dst_port = le32::from_ne(raw.remote_port);
271-
response.len = le32::from_ne(0);
272-
response.type_ = le16::from_ne(Type::Stream.into());
273-
if local_cid != u64::from(cid) && cid != u32::MAX {
274-
response.op = le16::from_ne(Op::Rst.into());
275-
} else {
276-
response.op = le16::from_ne(Op::Response.into());
277-
}
278-
response.flags = le32::from_ne(0);
279-
response.buf_alloc = le32::from_ne(
280-
crate::executor::vsock::RAW_SOCKET_BUFFER_SIZE as u32,
281-
);
282-
response.fwd_cnt = le32::from_ne(raw.fwd_cnt);
283-
});
284-
285-
let endpoint = VsockEndpoint::new(raw.remote_port, raw.remote_cid);
259+
const HEADER_SIZE: usize = size_of::<Hdr>();
260+
let mut driver_guard = hardware::get_vsock_driver().unwrap().lock();
261+
let local_cid = driver_guard.get_cid();
262+
263+
driver_guard.send_packet(HEADER_SIZE, |buffer| {
264+
let response = unsafe { &mut *buffer.as_mut_ptr().cast::<Hdr>() };
265+
266+
response.src_cid = le64::from_ne(local_cid);
267+
response.dst_cid = le64::from_ne(raw.remote_cid.into());
268+
response.src_port = le32::from_ne(port);
269+
response.dst_port = le32::from_ne(raw.remote_port);
270+
response.len = le32::from_ne(0);
271+
response.type_ = le16::from_ne(Type::Stream.into());
272+
if local_cid != u64::from(cid) && cid != u32::MAX {
273+
response.op = le16::from_ne(Op::Rst.into());
274+
} else {
275+
response.op = le16::from_ne(Op::Response.into());
276+
}
277+
response.flags = le32::from_ne(0);
278+
response.buf_alloc =
279+
le32::from_ne(crate::executor::vsock::RAW_SOCKET_BUFFER_SIZE as u32);
280+
response.fwd_cnt = le32::from_ne(raw.fwd_cnt);
281+
});
286282

287-
// Move the accepted connection to an ephemeral port so the
288-
// listener entry can be reset to Listen for the next accept.
289-
let conn_port = guard.move_to_ephemeral(port)?;
283+
let endpoint = VsockEndpoint::new(raw.remote_port, raw.remote_cid);
290284

291-
Poll::Ready(Ok((conn_port, endpoint)))
292-
};
285+
// Move the accepted connection to an ephemeral port so the
286+
// listener entry can be reset to Listen for the next accept.
287+
let conn_port = guard.move_to_ephemeral(port)?;
293288

294-
result
289+
Poll::Ready(Ok((conn_port, endpoint)))
295290
}
296291
_ => Poll::Ready(Err(Errno::Badf)),
297292
}

xtask/src/ci/qemu.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -185,10 +185,10 @@ impl Qemu {
185185
if matches!(
186186
image_name,
187187
"axum-example"
188-
| "http_server" | "http_server_poll"
188+
| "http_server"
189+
| "http_server_poll"
189190
| "http_server_select"
190-
| "vsock"
191-
| "vsock_server"
191+
| "vsock" | "vsock_server"
192192
) || self.devices.contains(&Device::CadenceGem)
193193
// sifive_u, on which we test CadenceGem, does not support software shutdowns, so we have to terminate the machine ourselves.
194194
{

0 commit comments

Comments
 (0)