Skip to content

Commit fae159a

Browse files
cagatay-ymkroening
authored andcommitted
test(virtio-net): have a CI test with small receive buffers
In order to ensure that the buffer merging works, make the receive buffers smaller in a CI step. Note, however, that this does not check if the MRG_RXBUF is available for the step. If it's not, the environment variable will have no effect.
1 parent 546e42a commit fae159a

1 file changed

Lines changed: 7 additions & 0 deletions

File tree

.github/workflows/ci.yml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -235,6 +235,13 @@ jobs:
235235
working-directory: .
236236
- run: cargo xtask ci rs --arch ${{ matrix.arch }} --profile ${{ matrix.profile }} --package httpd --features ci,hermit/dhcpv4,hermit/virtio-net qemu ${{ matrix.flags }} --devices virtio-net-pci
237237
if: matrix.arch != 'riscv64'
238+
# FIXME: this is broken on QEMU 8.2.2
239+
# Enable this once CI reaches QEMU 8.2.3 or QEMU 9.0.0
240+
# - run: cargo xtask ci rs --arch ${{ matrix.arch }} --profile ${{ matrix.profile }} --package httpd --features ci,hermit/dhcpv4,hermit/virtio-net qemu ${{ matrix.flags }} --devices virtio-net-pci
241+
# if: matrix.arch != 'riscv64'
242+
# env:
243+
# # The buffer is sized to be smaller than the packets received during DHCPv4 address acquisition and thus exercise the buffer merging code path.
244+
# HERMIT_MRG_RXBUF_SIZE: 200
238245
- run: cargo xtask ci rs --arch ${{ matrix.arch }} --profile ${{ matrix.profile }} --package httpd --features ci,hermit/virtio-net qemu --sudo --devices virtio-net-pci --tap
239246
if: matrix.arch != 'riscv64'
240247
- run: cargo xtask ci rs --arch ${{ matrix.arch }} --profile ${{ matrix.profile }} --package httpd --features ci,hermit/dhcpv4,hermit/virtio-net qemu ${{ matrix.flags }} --devices virtio-net-pci --no-default-virtio-features

0 commit comments

Comments
 (0)