Added support for metadata field in NFriend and some compilation tweaks#197
Added support for metadata field in NFriend and some compilation tweaks#197Cry-Luca wants to merge 5 commits into
metadata field in NFriend and some compilation tweaks#197Conversation
|
@Cry-Luca , there are 4 changes which really should be reviewed separately. They seem to be very localised and don't overlap in files changed, so it should be easy to unpack it into multiple commits.
On the last point: we have excluded static library from officially provided build method because of numerous support issues regarding dependencies symbol visibility (not possible to control in static builds) as well as complications with reproducing bugs in such builds: with a DLL we can just drop it into a local env and have a look. Even if we have no intention to support static builds, we can make small change to accept the then any users of the SDK are free to set NAKAMA_API themselves as they see fit and bear full responsibility for doing so consistently and in accordance with their build platform requirements. WDYT? |
|
Closed: will create separate pull requests. |
I wanted to create separate pull requests, but I guess it was my bad for not creating branches.
I know the static library related change could be controversial, feel free to ignore it.