reordering preprocessor if chain emmit type info#203
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts build configuration to (1) change how NAKAMA_API export/import macros are selected across platforms/compilers and (2) explicitly enable RTTI compile flags for the nakama-sdk-core-common object library.
Changes:
- Reordered
NAKAMA_APIpreprocessor selection to prioritizeFORCE_DLL_VISIBILITYover the Windows__declspecbranch. - Added conditional RTTI compile options (
-frtti//GR) tocore/commonwhen theRTTICMake option is enabled.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| interface/include/nakama-cpp/NExport.h | Reorders the export macro selection logic, adding a dedicated FORCE_DLL_VISIBILITY branch. |
| core/common/CMakeLists.txt | Adds RTTI compile flags for the nakama-sdk-core-common target when RTTI is enabled. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+24
to
+30
| #if defined FORCE_DLL_VISIBILITY | ||
| #ifdef NAKAMA_SHARED_LIBRARY_EXPORTS | ||
| #define NAKAMA_API __attribute__((visibility("default"))) | ||
| #else | ||
| #define NAKAMA_API | ||
| #endif | ||
| #elif defined _WIN32 || defined __CYGWIN__ || defined FORCE_DLL_IMPORT_EXPORT |
Comment on lines
+40
to
+44
| if (RTTI) | ||
| if (NOT MSVC) | ||
| target_compile_options(nakama-sdk-core-common PRIVATE "-frtti") | ||
| else() | ||
| target_compile_options(nakama-sdk-core-common PRIVATE "/GR") |
andresfelipemendez
force-pushed
the
update-sdk
branch
from
c26df71 to
4d6df75
Compare
redbaron
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.