Classify Node.js resolve failures via the failure framework#1687
Merged
Conversation
This was referenced Jun 29, 2026
colincasey
marked this pull request as ready for review
June 29, 2026 20:04
edmorley
approved these changes
Jun 30, 2026
Base automatically changed from
error-handling/phase-1-task-1-relocate-node
to
main
July 6, 2026 13:50
…node assertion
Wrapping _install in `if ! { ... | tee }` disables errexit inside the
function body, so the bare `false` at the download and checksum failure
sites no longer aborted the install — _install fell through to tar/chmod
and could exit 0 when a stale /tmp/node.tar.gz was present. Use explicit
`return 1` so the failure propagates. Also fix the testInvalidNode stderr
assertion, which still expected the reworded "Error:" prefix after the
message was restored to its original verbatim text.
colincasey
force-pushed
the
error-handling/phase-1-task-2-classify-resolve
branch
from
July 6, 2026 14:05
919bf0f to
71f4d8e
Compare
colincasey
enabled auto-merge (squash)
July 6, 2026 14:06
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues the migration off the global
ERRtrap. Node.js version-resolution failures (an unresolvable version, or an invalid semver requirement) are now classified inside theruntimes::nodejsmodule at the point of failure, and the legacyfail_bin_install/fail_node_install/fail_invalid_semverhandlers are deleted. The user-facing error text is carried over verbatim.Second of three stacked PRs; based on #1686.
W-23231569