Skip to content

Commit 82aaa01

Browse files
committed
Fix inaccurate PYTHONUNBUFFERED comment
`PYTHONUNBUFFERED` affects stdout and stderr, not stdin: https://docs.python.org/3/using/cmdline.html#envvar-PYTHONUNBUFFERED And updates the comment to actually explain the why not the what. GUS-W-23030029.
1 parent 7db11ed commit 82aaa01

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

bin/compile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ python_home='/app/.heroku/python'
7575
# using `/app` paths which will still work at run-time after relocation. Amongst other things, this
7676
# ensures that the shebang lines in the entrypoint scripts of installed packages are correct.
7777
export PATH="/app/.heroku/python/bin:${PATH}"
78-
# Tell Python to not buffer its stdin/stdout.
78+
# Disable Python's output buffering to ensure logs aren't dropped if an app crashes.
7979
export PYTHONUNBUFFERED=1
8080
# Ensure Python uses a Unicode locale, to prevent the issues described in:
8181
# https://github.com/docker-library/python/pull/570

0 commit comments

Comments
 (0)