Fix intermittent one-off dyno test failures from extra trailing newline#2115
Merged
Merged
Conversation
The platform log stream that captures one-off dyno (`app.run`) output occasionally appends an extra trailing newline, which intermittently breaks exact-match (`.to eq`) output assertions. For example: https://github.com/heroku/heroku-buildpack-python/actions/runs/28526498507/job/85081876325?pr=2110#step:5:589 This is the same flakiness that #2102 fixed for the `profile.d/` scripts test. Reuses the existing `normalize_trailing_newlines` spec helper to absorb the spurious newline while still asserting on the rest of the output exactly, applying it to the seven `app.run` exact-match assertions. GUS-W-23366753.
edmorley
marked this pull request as ready for review
July 8, 2026 14:49
edmorley
enabled auto-merge (squash)
July 8, 2026 14:49
colincasey
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The platform log stream that captures one-off dyno (
app.run) output occasionally appends an extra trailing newline, which intermittently breaks exact-match (.to eq) output assertions. For example:https://github.com/heroku/heroku-buildpack-python/actions/runs/28526498507/job/85081876325?pr=2110#step:5:589
This is the same flakiness that #2102 fixed for the
profile.d/scripts test. Reuses the existingnormalize_trailing_newlinesspec helper to absorb the spurious newline while still asserting on the rest of the output exactly, applying it to the sevenapp.runexact-match assertions.GUS-W-23366753.