fix: validate secondary_link URL when value is present

The URL validation loop skipped secondary_link entirely due to an
overly broad exclusion (`field != "secondary_link"`). This meant a
secondary_link containing spaces or missing the https:// scheme
would pass validation silently.

Change the condition so that empty optional fields are skipped (via
`continue`), but non-empty values are always validated regardless of
which field they belong to. The required-field check earlier in the
function already ensures primary_link and author_link are present.

Author: ashsolei

scripts/resources/parse_issue_form.py

@@ -173,11 +173,12 @@ def validate_parsed_data(data: dict[str, str]) -> tuple[bool, list[str], list[st
     url_fields = ["primary_link", "secondary_link", "author_link"]
     for field in url_fields:
         value = data.get(field, "").strip()
-        if value and field != "secondary_link":  # secondary is optional
-            if not value.startswith("https://"):
-                errors.append(f"{field} must start with https://")
-            elif " " in value:
-                errors.append(f"{field} contains spaces")
+        if not value:
+            continue  # required-field check above handles primary_link/author_link
+        if not value.startswith("https://"):
+            errors.append(f"{field} must start with https://")
+        elif " " in value:
+            errors.append(f"{field} contains spaces")
 
     # Validate license
     if data.get("license") == "No License / Not Specified":