add recommended locations, rename columns, add tests

Author: phm07

docs/reference/manual/hcloud_server-type_list.md

@@ -43,7 +43,7 @@ var ListCmd = &base.ListCmd[*hcloud.ServerType, schema.ServerType]{
 					",",
 				)
 			}).
-			AddFieldFn("available", func(serverType *hcloud.ServerType) string {
+			AddFieldFn("location_available", func(serverType *hcloud.ServerType) string {
 				now := time.Now()
 				return strings.Join(
 					listLocationNames(serverType, func(l hcloud.ServerTypeLocation) bool {
@@ -52,6 +52,14 @@ var ListCmd = &base.ListCmd[*hcloud.ServerType, schema.ServerType]{
 					",",
 				)
 			}).
+			AddFieldFn("location_recommended", func(serverType *hcloud.ServerType) string {
+				return strings.Join(
+					listLocationNames(serverType, func(l hcloud.ServerTypeLocation) bool {
+						return !l.Recommended
+					}),
+					",",
+				)
+			}).
 			AddFieldAlias("storagetype", "storage type").
 			AddFieldFn("memory", func(serverType *hcloud.ServerType) string {
 				return fmt.Sprintf("%.1f GB", serverType.Memory)

internal/cmd/servertype/list.go

@@ -46,17 +46,18 @@ func TestList(t *testing.T) {
 				Disk:         80,
 				StorageType:  hcloud.StorageTypeLocal,
 				Locations: []hcloud.ServerTypeLocation{
-					{Location: &hcloud.Location{ID: 1, Name: "fsn1"}, DeprecatableResource: serverTypeDeprecation},
-					{Location: &hcloud.Location{ID: 2, Name: "nbg1"}},
-					{Location: &hcloud.Location{ID: 3, Name: "hel1"}},
+					{Location: &hcloud.Location{ID: 1, Name: "fsn1"}, Available: false, Recommended: false,
+						DeprecatableResource: serverTypeDeprecation},
+					{Location: &hcloud.Location{ID: 2, Name: "nbg1"}, Available: true, Recommended: false},
+					{Location: &hcloud.Location{ID: 3, Name: "hel1"}, Available: true, Recommended: true},
 				},
 			},
 		}, nil)
 
-	out, errOut, err := fx.Run(cmd, []string{})
+	out, errOut, err := fx.Run(cmd, []string{"-o=columns=id,name,cores,cpu_type,architecture,memory,disk,location,location_available,location_recommended"})
 
-	expOut := `ID    NAME   CORES   CPU TYPE   ARCHITECTURE   MEMORY   DISK    LOCATION
-123   test   2       shared     arm            8.0 GB   80 GB   nbg1,hel1
+	expOut := `ID    NAME   CORES   CPU TYPE   ARCHITECTURE   MEMORY   DISK    LOCATION    LOCATION AVAILABLE   LOCATION RECOMMENDED
+123   test   2       shared     arm            8.0 GB   80 GB   nbg1,hel1   nbg1,hel1            hel1
 `
 
 	require.NoError(t, err)